Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Deprecate *Props and complete slots, slotProps #44913

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Menu] Deprecate *Props and complete slots, slotProps #44913

wants to merge 9 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 2, 2025 •
edited
Loading

Part of #41281

  • Deprecate MenuListProps and TransitionProps.
  • Added slots.transition and slots.list
  • Added a codemod for migration

@siriwatknp siriwatknp requested a review from DiegoAndai January 2, 2025 07:54
@siriwatknp siriwatknp added the component: menu This is the name of the generic UI component, not the React module! label Jan 2, 2025
@mui-bot
Copy link

mui-bot commented Jan 2, 2025 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c3c193a

@siriwatknp siriwatknp marked this pull request as ready for review January 2, 2025 11:47
@siriwatknp siriwatknp mentioned this pull request Jan 2, 2025
Open
35 tasks
DiegoAndai
DiegoAndai reviewed Jan 8, 2025
View reviewed changes
packages/mui-material/src/Menu/Menu.js Outdated Show resolved Hide resolved
packages/mui-material/src/Menu/Menu.js Outdated Show resolved Hide resolved
DiegoAndai
DiegoAndai reviewed Jan 9, 2025
View reviewed changes
packages/mui-material/src/Menu/Menu.js
* [Follow this guide](https://mui.com/material-ui/transitions/#transitioncomponent-prop) to learn more about the requirements for this component.
* @default Grow
*/
TransitionComponent: PropTypes.elementType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this one? slots.transition should be used instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because I move TransitionComponent to the the props, let me find other way.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siriwatknp @mui-bot @DiegoAndai