[material-ui][Input] Remove unused classes from InputClasses interface #44987
+17
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-44987--material-ui.netlify.app/ Bundle size report |
aarongarciah
requested review from
siriwatknp
and removed request for
aarongarciah
sai6855
added
the
component: text field
sai6855
commented
Jan 10, 2025
| /** Styles applied to the root element if the component is focused. */ | ||
| focused: string; | ||
| /** Styles applied to the root element if `disabled={true}`. */ | ||
| disabled: string; | ||
| /** Styles applied to the root element if color secondary. */ | ||
| colorSecondary: string; |
There was a problem hiding this comment.
Instead of adding the class to the DOM, I chose to remove it here. The fact that no users have reported this issue, even though it has likely existed for a long time (possibly since v5), suggests that it is not widely used. Therefore, I decided to remove the class instead of adding it to the DOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused classes from InputClasses interface, removed classes doesn't actually end up in dom and just present in interface, added tests to verify same
I found this while working on deprecating composed classes for Input component