Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] a few fixes uncovered during ESM updates #45031

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 15, 2025

Issues uncovered in #43264.

  • replace .d.ts files without corresponding .js file with .ts files. When resolving to the final path in .d.ts these can't find a souce file otherwise.
  • ☝️ uncovered an issue with missing types for LoadingButton. It's now exporting ButtonClassKey instead of LoadingButtonClassKey, etc... But the labs package tries to import those interfaces. I just alias them to fix this.
  • Use api.env() in babel config instead of reading the env var directly
  • Remove conflicting usage of both data-grid and data-grid-pro theme augmentation. It's one or the other.
  • Support for import('') in types and dynamic import when resolving extensions
  • Correct import from @mui/material/* inside of the @mui/material package
  • Export a few types that were referenced but not exported
  • Correct mui-types alias, it doesn't have a src folder

Edit:
closes #45072

@Janpot Janpot added the bug 🐛 Something doesn't work label Jan 15, 2025
@mui-bot
Copy link

mui-bot commented Jan 15, 2025

Netlify deploy preview

https://deploy-preview-45031--material-ui.netlify.app/

OverridableComponent: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 9250485

@Janpot Janpot marked this pull request as ready for review January 15, 2025 15:16
@Janpot Janpot requested a review from siriwatknp January 15, 2025 15:17
@Janpot Janpot changed the title [code-infra] Bring a few fixes from ESM upates [code-infra] Bring a few fixes uncovered during ESM updates Jan 15, 2025
@Janpot Janpot changed the title [code-infra] Bring a few fixes uncovered during ESM updates [code-infra] a few fixes uncovered during ESM updates Jan 15, 2025
@DiegoAndai DiegoAndai self-requested a review January 23, 2025 12:34
@DiegoAndai DiegoAndai added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Jan 23, 2025
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Janpot Janpot merged commit 137c02f into mui:master Jan 23, 2025
22 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work needs cherry-pick The PR should be cherry-picked to master after merge v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lab] themeAugmentation type definition is broken in v6.4.0
3 participants