Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix corepack and pnpm installation in CircleCI #45185

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Feb 3, 2025

Fixes failing CI pipelines, e.g. https://app.circleci.com/pipelines/github/mui/material-ui/147263/workflows/c200ca76-d4b0-48f4-896f-9717bbdfcec0

It was caused by an upstream issue with corepack: nodejs/corepack#612

See mui/base-ui#1405 for more details, it's the same fix ~

@mj12albert mj12albert added the core Infrastructure work going on behind the scenes label Feb 3, 2025
@mui-bot
Copy link

mui-bot commented Feb 3, 2025

Netlify deploy preview

https://deploy-preview-45185--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0bf7a57

@mj12albert mj12albert marked this pull request as ready for review February 3, 2025 08:08
@mj12albert mj12albert requested a review from a team February 3, 2025 08:08
@aarongarciah aarongarciah requested a review from Janpot February 3, 2025 08:10
@mj12albert mj12albert merged commit 480f421 into mui:master Feb 3, 2025
20 checks passed
@mj12albert mj12albert deleted the fix/corepack-ci branch February 3, 2025 08:48
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Feb 3, 2025

I think this should be added in v6.x branch as well. It is failing in cherry-pick branches as well: #45191

@DiegoAndai
Copy link
Member

Cherry-picked to v6: #45194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants