[core] Update branch switch tags #45198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
reviewed
Feb 4, 2025
|
@aarongarciah these pointers are for us to manually go through on a major version branch split and major stable releases, so I don't know if there's something we could test 😅 This is what I followed on the latest v6/v7 branch split, so maybe that's our test that this will work in the future as well? |
|
@DiegoAndai ah! Got it. I thought we had some kind of automation with some of this stuff. ✅ |
aarongarciah
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #45132 (comment):
We're using
#default-branch-switchto mark where changes are required, but with the new protocol, some of these changes happen onmasterbranch and others onv*.xbranch, so the comment becomes confusing. There are 4 types of changes that are encompassed under this tag:latest->next) inmaster(e.g., #45132)mui.com->next.mui.com) inmaster(e.g., #45132)https://github.com/mui/material-ui/tree/master->github.com/mui/material-ui/tree/v*.x) inv*.x(e.g., #45133)master->v*.x) inv*.x(e.g., #45133)This PR splits these into 4 different tags:
#npm-tag-reference#host-reference#repo-reference#target-branch-referenceBy splitting them, it will be easier to follow the branch split protocol and understand what each one refers to.
I used
referenceinstead ofswitchas I think it's more descriptive and reads better: "Here's is a reference of the npm tag/host/repo/target branch"