Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add migration guide for package layout changes #45222

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 5, 2025

Add a migration guide for #43264

@Janpot Janpot added the docs Improvements or additions to the documentation label Feb 5, 2025
@Janpot Janpot marked this pull request as ready for review February 5, 2025 17:38
@Janpot Janpot requested a review from DiegoAndai February 5, 2025 17:38
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left two comments to be checked before merging.

// vite.config.js
resolve: {
alias: [
- {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I think we had a suggestion for this for Next.js as well, does the same logic apply?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, the issue this solved only applies to vite. maybe there was another issue I'm missing?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants