-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add migration guide for package layout changes #45222
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left two comments to be checked before merging.
// vite.config.js | ||
resolve: { | ||
alias: [ | ||
- { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point I think we had a suggestion for this for Next.js as well, does the same logic apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, the issue this solved only applies to vite. maybe there was another issue I'm missing?
Co-authored-by: Marija Najdova <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
Add a migration guide for #43264