[DataGrid] Fix null reference error in GridVirtualScrollbar (#15009)

mui · Nov 5, 2024 · 65aa556 · 65aa556
1 parent 4814c2f
commit 65aa556
Show file tree

Hide file tree

Showing 835 changed files with 15,198 additions and 10,261 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -110,7 +110,7 @@ jobs:
           name: '`pnpm dedupe` was run?'
           command: |
             # #default-branch-switch
-            if [[ $(git diff --name-status v7.x | grep pnpm-lock) == "" ]];
+            if [[ $(git diff --name-status master | grep pnpm-lock) == "" ]];
             then
                 echo "No changes to dependencies detected. Skipping..."
             else
@@ -160,7 +160,7 @@ jobs:
           name: '`pnpm prettier` changes committed?'
           command: |
             # #default-branch-switch
-            if [[ $(git diff --name-status v7.x | grep pnpm-lock) == "" ]];
+            if [[ $(git diff --name-status master | grep pnpm-lock) == "" ]];
             then
                 pnpm prettier --check
             else
@@ -203,13 +203,24 @@ jobs:
           name: '`pnpm @mui/x-charts-vendor build` was run?'
           command: |
             # #default-branch-switch 
-            if [[ $(git diff --name-status v7.x | grep pnpm-lock) == "" ]]; 
+            if [[ $(git diff --name-status master | grep pnpm-lock) == "" ]]; 
             then
               echo "No changes to dependencies detected. Skipping..."
             else
               pnpm --filter @mui/x-charts-vendor build
               git add -A && git diff --exit-code --staged
             fi
+      - run:
+          name: 'No dynamic date library import in the Pickers built types?'
+          command: |
+            pnpm --filter @mui/x-date-pickers* prebuild
+            pnpm --filter @mui/x-date-pickers* build:types
+            if grep -nr 'import("luxon")\|import("dayjs")\|import("moment")' --exclude Adapter*.d.ts packages/{x-date-pickers,x-date-pickers-pro}/build
+            then
+                exit 1
+            else
+                exit 0
+            fi
 
   test_browser:
     <<: *default-job

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -16,10 +16,10 @@ jobs:
       security-events: write
     steps:
       - name: Checkout repository
-        uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13
+        uses: github/codeql-action/init@662472033e021d55d94146f66f6058822b0b39fd # v3.27.0
         with:
           languages: typescript
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -29,4 +29,4 @@ jobs:
           # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
           # queries: security-extended,security-and-quality
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13
+        uses: github/codeql-action/analyze@662472033e021d55d94146f66f6058822b0b39fd # v3.27.0
diff --git a/.github/workflows/codspeed.yml b/.github/workflows/codspeed.yml
@@ -34,12 +34,12 @@ jobs:
           (github.event_name == 'pull_request' && github.event.action != 'labeled' && contains(github.event.pull_request.labels.*.name, 'component: charts'))
       }}
     steps:
-      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
         with:
           run_install: false
       - name: Use Node.js 20.x
-        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
         with:
           node-version: 20
           cache: 'pnpm' # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

diff --git a/.github/workflows/create-cherry-pick-pr.yml b/.github/workflows/create-cherry-pick-pr.yml
@@ -0,0 +1,18 @@
+name: Create cherry-pick PR
+on:
+  pull_request_target:
+    branches:
+      - 'v*.x'
+      - 'master'
+    types: ['closed']
+
+permissions: {}
+
+jobs:
+  create_pr:
+    name: Create cherry-pick PR
+    uses: mui/mui-public/.github/workflows/prs_create-cherry-pick-pr.yml@master
+    permissions:
+      contents: write
+      issues: write
+      pull-requests: write
diff --git a/.github/workflows/l10n.yml b/.github/workflows/l10n.yml
@@ -17,12 +17,12 @@ jobs:
       issues: write
     steps:
       - run: echo "${{ github.actor }}"
-      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
         with:
           run_install: false
       - name: Use Node.js 20.x
-        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
         with:
           node-version: 20
           cache: 'pnpm' # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

diff --git a/.github/workflows/priority-support-validation-prompt.yml b/.github/workflows/priority-support-validation-prompt.yml
@@ -31,7 +31,7 @@ jobs:
           body: |
             You have created a support request under the ["Priority Support"](https://mui.com/legal/technical-support-sla/#priority-support) terms, which is a paid add-on to MUI X Premium ⏰. Please validate your support key using the link below:
 
-            https://tools-public.mui.com/prod/pages/jyhs86t?repo=mui-x&issueId=${{ github.event.issue.number }}
+            https://tools-public.mui.com/prod/pages/validateSupport?repo=mui-x&issueId=${{ github.event.issue.number }}
 
             Do not share your support key in this issue!
 

diff --git a/.github/workflows/scorecards.yml b/.github/workflows/scorecards.yml
@@ -23,7 +23,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
 
@@ -44,6 +44,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: Upload to code-scanning
-        uses: github/codeql-action/upload-sarif@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13
+        uses: github/codeql-action/upload-sarif@662472033e021d55d94146f66f6058822b0b39fd # v3.27.0
         with:
           sarif_file: results.sarif
diff --git a/.github/workflows/vale-action.yml b/.github/workflows/vale-action.yml
@@ -12,7 +12,7 @@ jobs:
       contents: read
       pull-requests: write
     steps:
-      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: errata-ai/vale-action@d89dee975228ae261d22c15adcd03578634d429c # v2.1.1
         continue-on-error: true # GitHub Action flag needed until https://github.com/errata-ai/vale-action/issues/89 is fixed
         with:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,148 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## 7.22.1
-
-_Nov 1, 2024_
-
-We'd like to offer a big thanks to the 7 contributors who made this release possible. Here are some highlights ✨:
-
-- 🐞 Bugfixes
-- 📚 Documentation improvements
-- 🌍 Improve Polish (pl-PL) locale on the Date Pickers
-
-Special thanks go out to the community contributors who have helped make this release possible:
-@wojtkolos, @dpak-maurya, @k-rajat19.
-Following are all team members who have contributed to this release:
-@LukasTy, @arminmeh, @MBilalShafi, @KenanYusuf, @flaviendelangle.
-
-<!--/ HIGHLIGHT_ABOVE_SEPARATOR /-->
-
-### Data Grid
-
-#### `@mui/[email protected]`
-
-- [DataGrid] Fix right column group header border (#15152) @KenanYusuf
-- [DataGrid] Fix scroll jump when holding down arrow keys (#15167) @arminmeh
-- [DataGrid] Move `rowGroupingModelChange` handler to respective hook (#15127) @MBilalShafi
-- [DataGrid] Prevent error when deleting the last row (#15153) @dpak-maurya
-- [DataGrid] Fix overlay height in autoHeight mode (#15205) @cherniavskii
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`, plus:
-
-- [DataGridPro] Add list view tests (#15166) @KenanYusuf
-
-#### `@mui/[email protected]` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link 'Premium plan')
-
-- [DataGridPremium] Keep focus on the grouping cell on space bar press #15155 @k-rajat19
-
-### Date and Time Pickers
-
-#### `@mui/[email protected]`
-
-- [l10n] Improve Polish (pl-PL) locale (#15177) @wojtkolos
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`.
-
-### Tree View
-
-#### `@mui/[email protected]`
-
-- [TreeView] Export `TreeItem2DragAndDropOverlay` and `TreeItem2LabelInput` from the root of each package (#15208) @flaviendelangle
-- [TreeView] Fix drag and drop color usage (#15149) @LukasTy
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`.
-
-### Docs
-
-- [docs] Add section explaining how to keep the selection while filtering in Data grid docs (#15199) @arminmeh
-
-## 7.22.0
-
-_Oct 25, 2024_
-
-We'd like to offer a big thanks to the 11 contributors who made this release possible. Here are some highlights ✨:
-
-- 🛰 Introduce [server-side support for Data Grid row grouping](https://mui.com/x/react-data-grid/server-side-data/row-grouping/)
-- 🐞 Bugfixes
-- 📚 Documentation improvements
-- 🌍 Improve Portuguese (pt-BR) locale on the Data Grid component
-
-Special thanks go out to the community contributors who have helped make this release possible:
-@clins1994, @GITPHLAP, @k-rajat19, @kalyan90, @merotosc, @yash49.
-Following are all team members who have contributed to this release:
-@cherniavskii, @flaviendelangle, @LukasTy, @MBilalShafi, @romgrk.
-
-<!--/ HIGHLIGHT_ABOVE_SEPARATOR /-->
-
-### Data Grid
-
-#### `@mui/[email protected]`
-
-- [DataGrid] Fix `GridPanelAnchor` positioning (#15022) @k-rajat19
-- [DataGrid] Fix ugly prop-types for the `pageStyle` prop of the `GridPrintExportMenuItem` component (#15015) @flaviendelangle
-- [DataGrid] Fix value type in filter model for number and boolean column type (#14733) @k-rajat19
-- [DataGrid] Focus next row when the focused row is deleted (#15067) @cherniavskii
-- [DataGrid] Remove some usages of `<Box />` and `<Badge />` (#15013) @romgrk
-- [DataGrid] Fix number of rows to display for page size options with negative value (#14890) @kalyan90
-- [l10n] Improve Portuguese (pt-BR) locale (#15021) @k-rajat19
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`, plus:
-
-- [DataGridPro] Fix column pinning layout (#15073) @cherniavskii
-
-#### `@mui/[email protected]` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link 'Premium plan')
-
-Same changes as in `@mui/[email protected]`, plus:
-
-- [DataGridPremium] Server-side data source with row grouping (#15109) @MBilalShafi
-
-### Date and Time Pickers
-
-#### `@mui/[email protected]`
-
-- [pickers] Fix `DateCalendar` timezone management (#15119) @LukasTy
-- [pickers] Fix `DigitalClock` time options on a `DST` switch day (#15092) @LukasTy
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`.
-
-### Charts
-
-#### `@mui/[email protected]`
-
-- [charts] Export data type in `onAxisClick(_, data)` callback (#15038) @clins1994
-
-#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')
-
-Same changes as in `@mui/[email protected]`.
-
-### Tree View
-
-#### `@mui/[email protected]`
-
-- [TreeView] Make the cancellable event types public (#14992) @flaviendelangle
-
-### Docs
-
-- [docs] Fix typo in Tree View docs (#15047) @yash49
-
-### Core
-
-- [core] Adjust cherry-pick GH actions (#15101) @LukasTy
-- [core] Update prettier target branch (#15100) @MBilalShafi
-- [core] Update some `default-branch-switch` instances for `v7.x` (#15085) @MBilalShafi
-- [test] Revert to using `fireEvent` instead of `userEvent` (#14927) @LukasTy
-
 ## 7.21.0
 
 _Oct 17, 2024_
@@ -211,7 +69,7 @@ Same changes as in `@mui/[email protected]`.
 
 #### `@mui/[email protected]`
 
-- [TreeView] Fix `alpha` usage with CSS variables (#14969) @wangkailang
+- [TreeView] Fix `alpha()` usage with CSS variables (#14969) @wangkailang
 - [TreeView] Fix usage of the `aria-selected` attribute (#14991) @flaviendelangle
 - [TreeView] Fix hydration error (#15002) @flaviendelangle
 
@@ -431,7 +289,7 @@ Same changes as in `@mui/[email protected]`.
 - [code-infra] Remove custom playwright installation steps (#14728) @Janpot
 - [code-infra] Replace or remove all instances of `e` identifier (#14724) @samuelsycamore
 - [infra] Adds community contribution section to the changelog script (#14799) @michelengelen
-- [infra] Fix line break in Stack Overflow message @oliviertassinari
+- [infra] Fix line break in Stack Overflow message @oliviertassinari
 - [test] Fix `Escape` event firing event (#14797) @oliviertassinari
 
 ## 7.18.0
@@ -523,7 +381,7 @@ Same changes as in `@mui/[email protected]`.
 - [core] Fix 301 link to Next.js and git diff @oliviertassinari
 - [core] Fix failing CI on `master` (#14644) @cherniavskii
 - [core] Fix `package.json` repository rule @oliviertassinari
-- [core] MUI X repository moved to a new location @oliviertassinari
+- [core] MUI X repository moved to a new location @oliviertassinari
 - [docs-infra] Strengthen CSP (#14581) @oliviertassinari
 - [license] Finish renaming of LicensingModel (#14615) @oliviertassinari
 
@@ -547,7 +405,7 @@ We'd like to offer a big thanks to the 12 contributors who made this release pos
 
 - [DataGrid] Add "does not equal" and "does not contain" filter operators (#14489) @KenanYusuf
 - [DataGrid] Add demo to the "Custom columns" page that does not use generator (#13695) @arminmeh
-- [DataGrid] Fix Voice Over reading the column name twice (#14482) @arminmeh
+- [DataGrid] Fix VoiceOver reading the column name twice (#14482) @arminmeh
 - [DataGrid] Fix bug in CRUD example (#14513) @michelengelen
 - [DataGrid] Fix failing jsdom tests caused by `:has()` selectors (#14559) @KenanYusuf
 - [DataGrid] Refactor string operator filter functions (#14564) @KenanYusuf
@@ -1367,7 +1225,7 @@ _Jul 5, 2024_
 We'd like to offer a big thanks to the 7 contributors who made this release possible. Here are some highlights ✨:
 
 - 🔄 Add loading overlay variants, including a skeleton loader option to the Data Grid component. See [Loading overlay docs](https://mui.com/x/react-data-grid/overlays/#loading-overlay) for more details.
-- 🌳 Add `selectItem` and `getItemDOMElement` methods to the TreeView component public API
+- 🌳 Add `selectItem()` and `getItemDOMElement()` methods to the TreeView component public API
 - ⛏️ Make the `usePickersTranslations` hook public in the pickers component
 - 🐞 Bugfixes
 
@@ -1412,7 +1270,7 @@ Same changes as in `@mui/[email protected]`.
 
 #### `@mui/[email protected]`
 
-- [TreeView] Add `selectItem` and `getItemDOMElement` methods to the public API (#13485) @flaviendelangle
+- [TreeView] Add `selectItem()` and `getItemDOMElement()` methods to the public API (#13485) @flaviendelangle
 
 ### Docs
 
@@ -3044,7 +2902,8 @@ Same changes as in `@mui/[email protected]`.
   ```
 
 - The headless field hooks (e.g.: `useDateField`) now returns a new prop called `enableAccessibleFieldDOMStructure`.
-  This property is utilized to determine whether the anticipated UI is constructed using an accessible DOM structure. Learn more about this new [accessible DOM structure](/x/react-date-pickers/fields/#accessible-dom-structure).
+  This property is utilized to determine whether the anticipated UI is constructed using an accessible DOM structure.
+  Learn more about this new accessible DOM structure in the [v8 migration guide](https://next.mui.com/x/migration/migration-pickers-v7/#new-dom-structure-for-the-field).
 
   When building a custom UI, you are most-likely only supporting one DOM structure, so you can remove `enableAccessibleFieldDOMStructure` before it is passed to the DOM:
 

diff --git a/changelogOld/CHANGELOG.v5.md b/changelogOld/CHANGELOG.v5.md
@@ -956,7 +956,7 @@ We'd like to offer a big thanks to the 10 contributors who made this release pos
 
 - [docs] New location for the legal content (#5595) @oliviertassinari
 - [docs] Update description of `maxDateTime` prop (#5639) @jurecuhalev
-- [docs] Add missing `date-fns` dependency when opening Codesandbox demo (#5692) @cherniavskii
+- [docs] Add missing `date-fns` dependency when opening CodeSandbox demo (#5692) @cherniavskii
 
 ### Core
 
@@ -2819,7 +2819,7 @@ _Nov 4, 2021_
 - [core] Group update of MUI Core (#3055) @oliviertassinari
 - [core] Ignore `*.tsbuildinfo` files (#3068) @m4theushw
 - [core] Implement tree-based row management (#2996) @flaviendelangle
-- [core] Invert Codesandbox examples on README (#3073) @flaviendelangle
+- [core] Invert CodeSandbox examples on README (#3073) @flaviendelangle
 - [core] Prefix selectors from `useGridContainerProps` with `unsafe` (#3002) @flaviendelangle
 - [core] Reduce `setGridState` and `applyFilters` call when updating `filterModel` (#3023) @flaviendelangle
 - [core] Reduce styles complexity (#3012) @DanailH

diff --git a/changelogOld/CHANGELOG.v6.md b/changelogOld/CHANGELOG.v6.md
@@ -20,7 +20,7 @@ Same changes as in `@mui/[email protected]`.
 
 ### Docs
 
-- [docs] Use MUI X v6 in Codesandbox and Stackblitz demos (#12838) @cherniavskii
+- [docs] Use MUI X v6 in CodeSandbox and StackBlitz demos (#12838) @cherniavskii
 
 ## 6.19.11
 
@@ -2596,7 +2596,7 @@ We'd like to offer a big thanks to the 12 contributors who made this release pos
 - [docs] Fix date pickers typo in the docs (#8939) @richbustos
 - [docs] Fix master detail demo (#8894) @m4theushw
 - [docs] Fix typo in clipboard docs (#8971) @MBilalShafi
-- [docs] Reduce list of dependencies in Codesandbox/Stackblitz demos (#8535) @cherniavskii
+- [docs] Reduce list of dependencies in CodeSandbox/StackBlitz demos (#8535) @cherniavskii
 
 ### Core
 

diff --git a/docs/.link-check-errors.txt b/docs/.link-check-errors.txt
@@ -1,2 +1,3 @@
 Broken links found by `docs:link-check` that exist:
 
+- https://mui.com/x/react-date-pickers/fields/#accessible-dom-structure