Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Russian (ru-RU) locale on the DataGrid #10407

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

NKodos
Copy link
Contributor

@NKodos NKodos commented Sep 20, 2023

Updated remaining keys in the localization file for Russian (ru-RU) language #3211

@mui-bot
Copy link

mui-bot commented Sep 20, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10407--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -204.8 20 -204.8 -71.84 96.772
Sort 100k rows ms 708.1 1,631.9 1,412.5 1,280.42 308.142
Select 100k rows ms 614.4 826.1 719.8 719.34 83.352
Deselect 100k rows ms 156.5 263 177.2 188.34 39.166

Generated by 🚫 dangerJS against edf2166

@flaviendelangle flaviendelangle added the l10n localization label Sep 20, 2023
@MBilalShafi MBilalShafi added the component: data grid This is the name of the generic UI component, not the React module! label Sep 22, 2023
@MBilalShafi MBilalShafi changed the title [DataGrid] Improve Russian (ru-RU) locale [l10] Improve Russian (ru-RU) locale on the DataGrid Sep 22, 2023
@MBilalShafi MBilalShafi changed the title [l10] Improve Russian (ru-RU) locale on the DataGrid [l10n] Improve Russian (ru-RU) locale on the DataGrid Sep 22, 2023
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, you may have to run yarn l10n after updating the locale keys to update the data.json dictionary.

packages/grid/x-data-grid/src/locales/ruRU.ts Outdated Show resolved Hide resolved
@MBilalShafi MBilalShafi merged commit af3749b into mui:master Sep 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants