[charts] Introduce hideLegend prop
#15277
Open
+110
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-15277--material-ui-x.netlify.app/ |
JCQuintas
reviewed
Nov 5, 2024
Comment on lines
143
to
152
| <PiePlot slots={slots} slotProps={slotProps} onItemClick={onItemClick} /> | ||
| <ChartsOverlay loading={loading} slots={slots} slotProps={slotProps} /> | ||
| {!hideLegend && ( | ||
| <ChartsLegend | ||
| direction="column" | ||
| position={{ vertical: 'middle', horizontal: isRtl ? 'left' : 'right' }} | ||
| slots={slots} | ||
| slotProps={slotProps} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
This is just adding to the file instead of changing a single line 😅
There was a problem hiding this comment.
Oopsi, bad cherry pick resolution
CodSpeed Performance ReportMerging #15277 will not alter performanceComparing Summary
|
JCQuintas
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15186
Will need to #15276 to highlight this props in the "Remove legend props" section for users who did only
legend={{ hidden: true }}Changelog
If you find
slotProps={{ legend: { hidden: true } }}too long, you can now usehideLegendprop to prevent rendering the legend.