Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] React 19 support #15342

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[WIP] React 19 support #15342

wants to merge 16 commits into from
+234 −144

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Nov 8, 2024 •
edited
Loading

Closes #13356

To run locally, after checkout run
pnpm use-react-version rc && pnpm use-material-ui-v6 (since v5 does not support r19)

building the packages works fine

some tests are still failing (would appreciate if someone from @mui/explore would look at the one with datepicker)

Test updates done in a same way and for the same reasons as in
mui/material-ui#43155

@arminmeh arminmeh added component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! component: charts This is the name of the generic UI component, not the React module! React 19 support PRs required to support React 19 labels Nov 8, 2024
@mui-bot
Copy link

mui-bot commented Nov 8, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15342--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 474996e

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15342 will degrade performances by 26.5%

Comparing arminmeh:react-19 (474996e) with master (0da596e)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 4 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master arminmeh:react-19 Change
⚡ ScatterChart with big data amount 536.1 ms 480.3 ms +11.61%
❌ ScatterChartPro with big data amount 168 ms 228.5 ms -26.5%

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 15, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy Awaiting requested review from LukasTy

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: charts This is the name of the generic UI component, not the React module! component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! React 19 support PRs required to support React 19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] React 19 support
2 participants
@arminmeh @mui-bot