Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Ukrainian (uk-UA) locale #3586

Merged
merged 4 commits into from
Jan 12, 2022
Merged

[l10n] Improve Ukrainian (uk-UA) locale #3586

merged 4 commits into from
Jan 12, 2022

Conversation

Neonin
Copy link
Contributor

@Neonin Neonin commented Jan 9, 2022

@m4theushw m4theushw added the l10n localization label Jan 10, 2022
cherniavskii
cherniavskii requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I have left few minor suggestions

@Neonin
Copy link
Contributor Author

Neonin commented Jan 11, 2022 •
edited
Loading

Thanks for your contribution! I have left few minor suggestions

Thanks, guys, for your time and excellent feedback.

cherniavskii
cherniavskii requested changes Jan 12, 2022
View reviewed changes
packages/grid/_modules_/grid/locales/ukUA.ts Outdated Show resolved Hide resolved
packages/grid/_modules_/grid/locales/ukUA.ts Outdated Show resolved Hide resolved
@m4theushw m4theushw changed the title [l10n] Improve Ukraine (uk-UA) locale [l10n] Improve Ukraine (ukUA) locale Jan 12, 2022
cherniavskii
cherniavskii approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@cherniavskii cherniavskii changed the title [l10n] Improve Ukraine (ukUA) locale [l10n] Improve Ukrainian (ukUA) locale Jan 12, 2022
@cherniavskii cherniavskii merged commit c9dba7c into mui:master Jan 12, 2022
@m4theushw
Copy link
Member

@cherniavskii Could you update #3211? The instructions are in the issue description.

@Neonin Neonin deleted the i10n/update_ukUA_locales branch January 12, 2022 16:43
@cherniavskii
Copy link
Member

@m4theushw sure

@oliviertassinari oliviertassinari changed the title [l10n] Improve Ukrainian (ukUA) locale [l10n] Improve Ukrainian (uk-UA) locale Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw left review comments

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neonin @m4theushw @cherniavskii