-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix permissions in no-response
workflow
#6658
Conversation
Signed-off-by: Andrew Cherniavskii <[email protected]>
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it needs write permission on PR
Did you try it on your repo to verify it fixes the problem?
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Andrew Cherniavskii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I have made a dumb mistake on this one, thanks for the 🧹 behind me. We can see the error in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153
I have applied the same fix to the other repositories.
I went on the older issues to fill the gap where the GitHub Action didn't run these last few days.
I have updated MUI org permissions to be:
I have opened lee-dohm/no-response#377 hoping that it might get released, our GitHub Actions should have failed.
no-response
workflowno-response
workflow
See mui/mui-x#6658 for more details.
See mui/mui-x#6658 for more details.
See mui/mui-x#6658 for more details.
See mui/mui-x#6658 for more details.
See mui/mui-x#6658 for more details.
Fixes a regression from #6396 (comment)