fix: "Unexpected token ';'" in expressions with trailing ';' (#3147)

mui · Feb 1, 2024 · 8f57693 · 8f57693
1 parent fcd66c0
commit 8f57693
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/toolpad-app/src/toolpad/AppEditor/BindingEditor.tsx b/packages/toolpad-app/src/toolpad/AppEditor/BindingEditor.tsx
@@ -536,8 +536,11 @@ export function BindingEditorDialog<V>({
         (input as JsExpressionAttrValue).$$jsExpression,
         data!,
       );
+      // Remove trailing spaces, newline characters for cleanliness and
+      // trailing semicolons since they introduce crashes while evaluation
+      const cleanedExpression = jsExpression.trim().replace(/;*$/, '');
       newValue = {
-        $$jsExpression: jsExpression,
+        $$jsExpression: cleanedExpression,
       };
     }