Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
try to fix S2 tests on github
Browse files Browse the repository at this point in the history
muir committed Jul 25, 2024
1 parent e4bd314 commit 99ad00c
Showing 6 changed files with 23 additions and 11 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
@@ -24,8 +24,10 @@ jobs:
run: make calculate_coverage

- name: Upload coverage to Codecov
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2
uses: codecov/codecov-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
token: ${{ secrets.CODECOV_TOKEN }
version: "v0.1.15"
verbose: true
flags: go_tests
fail_ci_if_error: true
flags: go_tests
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ jobs:
Build-and-test:
strategy:
matrix:
go-version: [1.17.x, 1.18.x, 1.19.x]
go-version: [1.17.x, 1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
6 changes: 4 additions & 2 deletions .github/workflows/mysql.yml
Original file line number Diff line number Diff line change
@@ -60,9 +60,11 @@ jobs:
run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lsmysql/...

- name: Upload coverage to Codecov
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2
uses: codecov/codecov-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
token: ${{ secrets.CODECOV_TOKEN }
version: "v0.1.15"
verbose: true
flags: mysql_tests
fail_ci_if_error: true
flags: mysql_tests

6 changes: 4 additions & 2 deletions .github/workflows/pg.yml
Original file line number Diff line number Diff line change
@@ -58,8 +58,10 @@ jobs:
run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lspostgres/...

- name: Upload coverage to Codecov
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2
uses: codecov/codecov-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
token: ${{ secrets.CODECOV_TOKEN }
version: "v0.1.15"
verbose: true
flags: pg_tests
fail_ci_if_error: true
flags: pg_tests
12 changes: 9 additions & 3 deletions .github/workflows/s2.yml
Original file line number Diff line number Diff line change
@@ -29,7 +29,11 @@ jobs:

- name: sanity check using mysql client
run: |
mysql -u root -ptest -e "CREATE DATABASE libschematest" -h 127.0.0.1
mysql -u root -ptest -e "CREATE DATABASE libschematest partitions 2" -h 127.0.0.1
mysql -u root -ptest -e "set global snapshots_to_keep = 1" -h 127.0.0.1
mysql -u root -ptest -e "set global minimal_disk_space = 10" -h 127.0.0.1
mysql -u root -ptest -e "set global log_file_size_partitions = 1048576" -h 127.0.0.1
mysql -u root -ptest -e "set global log_file_size_ref_dbs = 1048576" -h 127.0.0.1
- name: Check out repository code
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -53,9 +57,11 @@ jobs:
run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lsmysql/... ./lssinglestore/...

- name: Upload coverage to Codecov
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2
uses: codecov/codecov-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
token: ${{ secrets.CODECOV_TOKEN }
version: "v0.1.15"
verbose: true
flags: singlestore_tests
fail_ci_if_error: true
flags: singlestore_tests

2 changes: 1 addition & 1 deletion lssinglestore/singlestore.go
Original file line number Diff line number Diff line change
@@ -185,7 +185,7 @@ func (p *SingleStore) CreateSchemaTableIfNotExists(ctx context.Context, _ *inter
}
if schema != "" {
_, err := d.DB().ExecContext(ctx, fmt.Sprintf(`
CREATE DATABASE IF NOT EXISTS %s
CREATE DATABASE IF NOT EXISTS %s PARTITIONS 2
`, schema))
if err != nil {
return errors.Wrapf(err, "Could not create libschema schema '%s'", schema)

0 comments on commit 99ad00c

Please sign in to comment.