-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test performance benchmark #38
base: trunk
Are you sure you want to change the base?
Conversation
Hi @swissspidy Sorry for ping. Do you know why the Performance workflow failed. What is the best way to debug the |
Hmm you might be running into swissspidy/wp-performance-action#224, which I thought I had been fixing in swissspidy/wp-performance-action#227. Let me merge that one and then you can try with |
Yes please |
OK I just merged it. Let me know if the |
Same error:
|
Where'd you run it? This PR still uses |
Working now. 🚀 |
Great, I'll tag a new release so that |
Performance Test Results Performance test results for 227d990 are in 🛎️! Tests
@swissspidy As i set |
That‘s not what the iterations config is for # Number of times the tests should be repeated.
#
# Default: 2
repetitions: ''
# Number of iterations (loops) within a single run.
#
# Default: 20
iterations: ''
so repetitions = how often the whole test suite rund = more table rows |
Performance Test Results Performance test results for 4c708e8 are in 🛎️! Tests
Per the job Artifacts JSON data [
{
"file": "/home/runner/work/_actions/swissspidy/wp-performance-action/v2/env/tests/performance/specs/main.spec.ts",
"title": "Tests",
"results": [
{
"wpDbQueries": [
101,
130,
95,
95,
95,
77,
76,
76,
76,
76
],
"wpMemoryUsage": [
55634136,
57976944,
57964040,
57960440,
57960440,
59122336,
59148856,
59149000,
59149000,
59149000
],
"wpBeforeTemplate": [
660,
625,
478,
471,
475
],
"wpTemplate": [
151,
398,
348,
345,
339
],
"wpTotal": [
811,
1023,
827,
816,
814,
517,
520,
516,
527,
518
],
"largestContentfulPaint": [
2215,
17596,
1578.9000000000233,
1583,
1579.5,
9920,
886.7999999999884,
1897.5,
1355.5999999999767,
1333.5
],
"timeToFirstByte": [
2003,
16470.29999999999,
1232.5,
1218.9000000000233,
1241.5,
2443.899999999965,
731.1999999999534,
1739.399999999965,
1201.899999999965,
1180.7000000000116
],
"lcpMinusTtfb": [
212,
1125.7000000000116,
346.4000000000233,
364.0999999999767,
338,
7476.100000000035,
155.60000000003492,
158.10000000003492,
153.70000000001164,
152.79999999998836
]
}
]
}
] |
Oooh.... I think I know what's going on. The JSON file structure just merges together all values from all URLs. I somehow didn't think of that when I added the multi-URL support 🤦 The reason you see different number of entries is because the first 5 are from Anyhow, it's utterly wrong to put all the results for a URL into the same array 🤦 I'll need to fix that. |
I just re-tagged v2 with the fix now |
🎉 Performance Test Results Performance test results for 4c708e8 are in 🛎️! URL:
URL:
|
I should probably make those labels more readable 🤔 The table is quite wide this way 😅 |
@swissspidy Sorry for ping. There tests shows lots of delay 10 minutes and show |
The issue is not a timeout ( 10 minutes is extremely high! ), but the In other words: the Playground server probably crashed and then Playwright tried for 10 minutes to still connect to it. |
Does it Performance action issue? or Playground? or Playwright? |
The Playground server crashing due to heavy load would be a Playground issue. |
No description provided.