This repository has been archived by the owner on May 10, 2024. It is now read-only.
updates libs #172
Merged
updates libs #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smulesoft
force-pushed
the
update_dependencies
branch
from
9bbe5b2 to
318b8f2
Compare
smulesoft
force-pushed
the
update_dependencies
branch
from
318b8f2 to
dbbcf5f
Compare
|
This is not enough. We need to update all dependencies as well: Btw, this should be taken of semi-auto-magically thanks to Greekeeper. I'll have someone from my team take a look and merge this. |
|
@jstoiko Ok, this is the only one I need for now, let me know how you want to do this. The sooner there is a new release the better. |
postatum
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Looks good to me.
I get an error when trying to run one of examples though. But that errors happens in master as well.
$ pwd
/projects/osprey/examples/custom-auth
$ node index.js
(node:8494) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'headers' of undefined
at /projects/osprey/lib/server.js:77:75
at Array.reduce (<anonymous>)
at /projects/osprey/lib/server.js:70:38
at Array.map (<anonymous>)
at /projects/osprey/lib/server.js:66:43
at Array.map (<anonymous>)
at addSecurityHeaders (/projects/osprey/lib/server.js:64:35)
at createServer (/projects/osprey/lib/server.js:27:10)
at /projects/osprey/osprey.js:43:21
(node:8494) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:8494) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
|
Created an issue for what I described #174 |
|
@postatum Thanks for the review. Will it automatically be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.