WIP - Add installer downloader and in-app upgrades backend #7583
Conversation
dlon
changed the title
dlon
force-pushed
the
installer-downloader
branch
from
8bdac28 to
bf3eeb4
Compare
mullvad-update/src/app.rs
Outdated
| } | ||
|
|
||
| impl<SigProgress, AppProgress> HttpAppDownloader<SigProgress, AppProgress> { | ||
| const MAX_SIGNATURE_SIZE: usize = 1 * 1024; |
mullvad-update/src/app.rs
Outdated
| #[derive(Debug)] | ||
| pub enum DownloadError { | ||
| FetchSignature(anyhow::Error), | ||
| FetchApp(anyhow::Error), | ||
| Verification(anyhow::Error), | ||
| } |
There was a problem hiding this comment.
These error variants are never matched on, and the enum doesn't implement the Error trait, so is there really any point to it? Why not just use anyhow?
There was a problem hiding this comment.
I get this warning when running cargo check
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package: C:\Users\Sebastian\Documents\Programming\mullvad\installer-downloader\Cargo.toml
workspace: C:\Users\Sebastian\Documents\Programming\mullvad\Cargo.toml
Is the opt level specified in installer-downloader being overwritten by the workspace level?
It isn't being correctly applied. This is noted in the toml file. I think it'll be replaced by a build script. |
| add_file_server_mock(&mut server, "/my_file", file_data); | ||
|
|
||
| // Interrupt after exactly half the file has been downloaded | ||
| let mut limited_buffer = vec![0u8; file_data.len() / 2].into_boxed_slice(); |
There was a problem hiding this comment.
.into_boxed_slice() and the following into_vec() aren't needed. The test compiles and passes when I remove them.
There was a problem hiding this comment.
Does it work without removing vec!? I was sure that it would automatically resize the buffer in that case. I'll try it, but somehow I trust it more knowing it's a fixed size.
There was a problem hiding this comment.
You're still creating the writer from a slice into the vec, so it can't modify the capacity, right?
| if active_download.is_some() { | ||
| continue; | ||
| } | ||
| let Some(version_info) = version_info.clone() else { | ||
| continue; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Perhaps we should log some warning here?
I think it should because it makes it easier to regenerate them if the SVGs are edited. |
dlon
force-pushed
the
installer-downloader
branch
from
ec26088 to
15fb2cc
Compare
mullvad-update/src/deserializer.rs
Outdated
| pub signed: Response, | ||
| } | ||
|
|
||
| /// Helper class that leaves the signed data untouched |
There was a problem hiding this comment.
:man-gesturing-no:
| /// Helper class that leaves the signed data untouched | |
| /// Helper type that leaves the signed data untouched |
| /// Beta preface text | ||
| pub const BETA_PREFACE_DESC: &str = "Want to try the new Beta version? "; | ||
| /// Beta link text | ||
| pub const BETA_LINK_TEXT: &str = "Click here!"; |
There was a problem hiding this comment.
Is the text really up to date with the design? Shouldn't it say "Want to try out new features? Try our new beta!"
Co-authored-by: Sebastian Holmin <[email protected]>
This also replaces the PGP verifier with a SHA256 checksum verifier
`format` was also updated to support signing
This brings down the binary size of installer-downloader from 2.3 M to 1.4 M with size optimizations enabled
dlon
force-pushed
the
installer-downloader
branch
from
ea86df4 to
ce4521b
Compare
Notably, this means that the loader must run as a privileged user
Co-authored-by: Joakim Hulthe <[email protected]>
dlon
force-pushed
the
installer-downloader
branch
from
ce4521b to
a72844c
Compare
This PR aims to introduce a minimal installer as well as most of the functionality for in-app upgrades (except UI). This is still a work in progress.
The main things that are missing:
The planned native module for the Electron frontend is not in scope for this PR.
Close DES-1685
Close DES-1684
Close DES-1641
Close DES-1640
Close DES-1571
This change is