-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set font size of dialog inputs to be title medium #7633
Set font size of dialog inputs to be title medium #7633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to only apply to the actual input in the textfields. While the placeholdertext /labeltext (for example: "Enter IP" in the "Add DNS server") has the same font size of 16pt. This is not a big deal and is not a blocker for the fix, just wanted to point it out 👍 .
Looks good! 🎉 Nice work 🙌 |
1487e32
to
01867eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
01867eb
to
dac51e4
Compare
They were using
bodyMedium
and that was changed to the default value.This PR set it explicitly to
titleMedium
to make it look like it was before the change ofbodyMedium
.This change is