Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set font size of dialog inputs to be title medium #7633

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Feb 10, 2025

They were using bodyMedium and that was changed to the default value.
This PR set it explicitly to titleMedium to make it look like it was before the change of bodyMedium.


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Feb 10, 2025
@Pururun Pururun requested review from kl, Rawa and mullmat February 10, 2025 12:09
Copy link

linear bot commented Feb 10, 2025

Copy link
Collaborator

@mullmat mullmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem to only apply to the actual input in the textfields. While the placeholdertext /labeltext (for example: "Enter IP" in the "Add DNS server") has the same font size of 16pt. This is not a big deal and is not a blocker for the fix, just wanted to point it out 👍 .

@Pururun
Copy link
Contributor Author

Pururun commented Feb 11, 2025

The changes seem to only apply to the actual input in the textfields. While the placeholdertext /labeltext (for example: "Enter IP" in the "Add DNS server") has the same font size of 16pt. This is not a big deal and is not a blocker for the fix, just wanted to point it out 👍 .

I made the placeholder use the same text style as the input text: (new style in the second image)
Screenshot_20250211_075509
Screenshot_20250211_075659

@mullmat
Copy link
Collaborator

mullmat commented Feb 12, 2025

The changes seem to only apply to the actual input in the textfields. While the placeholdertext /labeltext (for example: "Enter IP" in the "Add DNS server") has the same font size of 16pt. This is not a big deal and is not a blocker for the fix, just wanted to point it out 👍 .

I made the placeholder use the same text style as the input text: (new style in the second image) !

Looks good! 🎉 Nice work 🙌

@Pururun Pururun force-pushed the restore-input-font-sizes-for-dialogs-droid-1788 branch from 1487e32 to 01867eb Compare February 17, 2025 07:24
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kl kl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the restore-input-font-sizes-for-dialogs-droid-1788 branch from 01867eb to dac51e4 Compare February 17, 2025 11:01
@Pururun Pururun merged commit 0ae2c89 into main Feb 17, 2025
24 checks passed
@Pururun Pururun deleted the restore-input-font-sizes-for-dialogs-droid-1788 branch February 17, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants