-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an end to end test for UDP-over-TCP on port 80 #7668
Add an end to end test for UDP-over-TCP on port 80 #7668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
ios/MullvadVPNUITests/RelayTests.swift
line 199 at r1 (raw file):
let streamFromPeeerToRelay = try XCTUnwrap( capturedStreams .filter { $0.destinationAddress == connectedToIPAddress }.first
Is it enough to check that one stream on port 80 exists or does it make sense to verify that no other stream on a different port exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @SteffenErn)
ios/MullvadVPNUITests/RelayTests.swift
line 199 at r1 (raw file):
Previously, SteffenErn (Steffen Ernst) wrote…
Is it enough to check that one stream on port 80 exists or does it make sense to verify that no other stream on a different port exists?
The way the packet capture API was designed is not immediately obvious.
There will be 1 Stream
object exactly, that we capture here by filtering by connectedToIPAddress
As the router that does the capture is used by multiple teams, we only want to bother about the relay our device has connected to.
In a nutshell, this is only stream we care about here.
7268479
to
1dada3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPNUITests/RelayTests.swift
line 199 at r1 (raw file):
Previously, buggmagnet wrote…
The way the packet capture API was designed is not immediately obvious.
There will be 1Stream
object exactly, that we capture here by filtering byconnectedToIPAddress
As the router that does the capture is used by multiple teams, we only want to bother about the relay our device has connected to.
In a nutshell, this is only stream we care about here.
Ok, thanks for the clarification :)
1dada3e
to
58157b9
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
🚨 End to end tests failed. Please check the failed workflow run. |
This PR adds an end to end test that connects to a relay using UDP-over-TCP obfuscation on port80.
The test also verifies using packet capture that the traffic sent to the relay during its course is happening exclusively on port 80 using a TCP connection.
The PR also fixes an innocent mistake in
DetailsView.swift
and makes the chevron icon accessibility tap action actually expand the connection details.This change is