Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc stakingv4 #482

Merged
merged 19 commits into from
Feb 6, 2024
Merged

Doc stakingv4 #482

merged 19 commits into from
Feb 6, 2024

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Nov 9, 2022

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@mariusmihaic mariusmihaic self-assigned this Nov 15, 2022
@schimih schimih self-requested a review November 15, 2022 15:58
Copy link
Contributor

@schimih schimih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good text overall. I added just a few suggestions to bring some clarity...
Good job!

Comment on lines 8 to 12
Staking and delegation should be developed as time goes on. No system has to stay the same. Our assumptions of how the
market works and reacts may change over time, the same way it may change with users and markets.
Right now we have around 400 validators (running one or multiple nodes). Some of them are staking providers, while
others are individuals running validators directly. Although most of the nodes have a nice topUp on the top of the base
stake of 2.5k eGLD, others don't contribute to the network's security by adding more topUp.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Staking and delegation should be developed as time goes on. No system has to stay the same. Our assumptions of how the
market works and reacts may change over time, the same way it may change with users and markets.
Right now we have around 400 validators (running one or multiple nodes). Some of them are staking providers, while
others are individuals running validators directly. Although most of the nodes have a nice topUp on the top of the base
stake of 2.5k eGLD, others don't contribute to the network's security by adding more topUp.
Staking and delegation should be developed as time goes on. No system has to stay the same. Our assumptions of how the
the market works and reacts may change over time, the same way it may change with users and their needs.
We currently have around 400 validators (running one or multiple nodes). Some are staking providers, while others are individuals running validators directly. Although most nodes have a nice topUp on the top of the base stake of 2500 eGLD, others don't contribute to the network's security by adding more topUp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 2.5k -> 2.500

Comment on lines 20 to 21
- Big providers are getting bigger, it does not help with decentralization. 31% of validators are controlled by Elrond
Foundation. The top 11 staking agencies control 33%.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Big providers are getting bigger, it does not help with decentralization. 31% of validators are controlled by Elrond
Foundation. The top 11 staking agencies control 33%.
- Big providers are getting bigger, it does not help with decentralization. Elrond Foundation controls 31% of validators. The top 11 staking agencies control 33%.

- Big providers are putting up nodes in the waiting list - as they have little to lose and when somebody gets out, they
are the first to enter.

One of the first things we should eliminate is the additional queue and use the topUp value per node in order to decide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
One of the first things we should eliminate is the additional queue and use the topUp value per node in order to decide
One of the first things we should eliminate is the additional queue and use the topUp value per node to decide

are the first to enter.

One of the first things we should eliminate is the additional queue and use the topUp value per node in order to decide
which are the best nodes and select those at the end of the epoch to become active. Doing that, we do not limit the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which are the best nodes and select those at the end of the epoch to become active. Doing that, we do not limit the
which are the best nodes and select those at the end of the epoch to become active. By doing that, we do not limit the

One of the first things we should eliminate is the additional queue and use the topUp value per node in order to decide
which are the best nodes and select those at the end of the epoch to become active. Doing that, we do not limit the
entry of new validators as currently an old validator must leave in order for a new one to enter. The market will decide
the actual price of the node, but it is not a hard auction, better say, it is a soft auction, where everybody paying the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the actual price of the node, but it is not a hard auction, better say, it is a soft auction, where everybody paying the
the actual price of the node, but it is not a hard auction; better say, it is a soft auction, where everybody paying the


## One of my nodes was sent to auction during stakingV4 phase2. Will I loose rewards?

If one of your nodes is shuffled out into auction list during phase2 it will enter in competition with the other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If one of your nodes is shuffled out into auction list during phase2 it will enter in competition with the other
If one of your nodes is shuffled-out into auction list during the phase2, it will compete with the other

## One of my nodes was sent to auction during stakingV4 phase2. Will I loose rewards?

If one of your nodes is shuffled out into auction list during phase2 it will enter in competition with the other
existing nodes. In case you have enough topUP, **nothing changes, no rewards will be lost**. For owners that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
existing nodes. In case you have enough topUP, **nothing changes, no rewards will be lost**. For owners that
existing nodes. If you have enough topUp, **nothing changes, and you won't lose any rewards**. THis change


If one of your nodes is shuffled out into auction list during phase2 it will enter in competition with the other
existing nodes. In case you have enough topUP, **nothing changes, no rewards will be lost**. For owners that
contribute to the ecosystem and keep a nice topUp, this change will not have any negative impact. Of course, in case you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contribute to the ecosystem and keep a nice topUp, this change will not have any negative impact. Of course, in case you
will not negatively impact owners that contribute to the ecosystem and keep a nice topUp. Of course, if you have low topUp, or close to zero, your nodes might be unqualified and remain on the auction list.

If one of your nodes is shuffled out into auction list during phase2 it will enter in competition with the other
existing nodes. In case you have enough topUP, **nothing changes, no rewards will be lost**. For owners that
contribute to the ecosystem and keep a nice topUp, this change will not have any negative impact. Of course, in case you
have low topUp, or close to zero, your nodes might be unqualified and remain in auction list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
have low topUp, or close to zero, your nodes might be unqualified and remain in auction list.

"idle"(not participating in consensus) for 5 epochs. During this time, the node would not gain any rewards.

During stakingV4 phase2, no node from waiting is moved to active. If we were to keep the same configuration, a shuffled
out node from this phase would have to wait 6 epochs until eligible(if selected from auction) and therefore decreasing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
out node from this phase would have to wait 6 epochs until eligible(if selected from auction) and therefore decreasing
out node from this phase would have to wait for 6 epochs until eligible(if selected from auction) and therefore decreasing

@mariusmihaic mariusmihaic marked this pull request as ready for review January 18, 2024 14:10

- Limiting the number of nodes to 3200, creating an additional queue. New validators can join the network only if
someone leaves the system.
- Concentration of power among large providers, hindering decentralization. MultiversX Foundation together with the top

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase it, say that the top X agencies control 33%.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, good point, rephrased it

someone leaves the system.
- Concentration of power among large providers, hindering decentralization. MultiversX Foundation together with the top
11 staking agencies control 33%.
- Large providers strategically place nodes in the waiting list, taking advantage of their position when a slot becomes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted it

shard's waiting list.

In the current implementation, each node, regardless of its top-up, has equal chances of participating in the consensus.
However, starting with staking phase 4, validators with higher staked top-up will have higher chances of participation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually those nodes with no topup, or small topup will have really small chance to enter into validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed text to:

"Starting with staking phase 4, the probability of validators entering the validation process will be significantly influenced by the amount of their staked top-up. Validators with a higher staked top-up will have considerably greater chances of participation, while those with little or no top-up will find their chances of entering into validation markedly reduced."


Staking phase 4 will unfold in three consecutive steps, each corresponding to a specific epoch.

## Staking v4. Phase 1.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we named staking Phase 4. so I would change the "Phase" from this. It sounds band staking phase 4 phase 1. Just put step 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, renamed everywhere to step


:::note

The minimum required topUp per node, along with the real-time auction list, will be accessible in the explorer at all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is accessible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored here and in another place as well

@mariusmihaic mariusmihaic merged commit bb88859 into development Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants