Skip to content

Commit

Permalink
Fix after self-review.
Browse files Browse the repository at this point in the history
  • Loading branch information
andreibancioiu committed Oct 23, 2024
1 parent b281dd6 commit 14b6748
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion multiversx_sdk/abi/code_metadata_value.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def decode_top_level(self, data: bytes):

def set_payload(self, value: Any):
if isinstance(value, bytes):
self.value = CodeMetadata.from_bytes(value).serialize()
self.value = CodeMetadata.new_from_bytes(value).serialize()
elif isinstance(value, CodeMetadata):
self.value = value.serialize()
else:
Expand Down
2 changes: 1 addition & 1 deletion multiversx_sdk/core/code_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def __init__(self, upgradeable: bool = True, readable: bool = True, payable: boo
self.payable_by_contract = payable_by_contract

@classmethod
def from_bytes(cls, data: bytes) -> "CodeMetadata":
def new_from_bytes(cls, data: bytes) -> "CodeMetadata":
if len(data) != CODE_METADATA_LENGTH:
raise ValueError(f"code metadata buffer has length {len(data)}, expected {CODE_METADATA_LENGTH}")

Expand Down
12 changes: 6 additions & 6 deletions multiversx_sdk/core/code_metadata_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,33 @@
from multiversx_sdk.core.code_metadata import CodeMetadata


def test_code_metadata_from_bytes():
metadata = CodeMetadata.from_bytes(bytes([0x05, 0x00]))
def test_code_metadata_new_from_bytes():
metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x00]))
assert metadata.upgradeable == True
assert metadata.readable == True
assert metadata.payable == False
assert metadata.payable_by_contract == False

metadata = CodeMetadata.from_bytes(bytes([0x05, 0x06]))
metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x06]))
assert metadata.upgradeable == True
assert metadata.readable == True
assert metadata.payable == True
assert metadata.payable_by_contract == True

metadata = CodeMetadata.from_bytes(bytes([0x05, 0x00]))
metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x00]))
assert metadata.upgradeable == True
assert metadata.readable == True
assert metadata.payable == False
assert metadata.payable_by_contract == False

metadata = CodeMetadata.from_bytes(bytes([0x00, 0x00]))
metadata = CodeMetadata.new_from_bytes(bytes([0x00, 0x00]))
assert metadata.upgradeable == False
assert metadata.readable == False
assert metadata.payable == False
assert metadata.payable_by_contract == False

with pytest.raises(ValueError, match="code metadata buffer has length 4, expected 2"):
CodeMetadata.from_bytes(bytes([0x00, 0x01, 0x02, 0x03]))
CodeMetadata.new_from_bytes(bytes([0x00, 0x01, 0x02, 0x03]))


def test_code_metadata_serialize():
Expand Down

0 comments on commit 14b6748

Please sign in to comment.