Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional dependency import #182

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix optional dependency import #182

merged 2 commits into from
Jan 16, 2025

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Jan 16, 2025

Now, when the package is installed without the optional dependency it displays an error message when used:

 ImportError: The ledgercomm package is not installed. Please install it using pip install multiversx_sdk[ledger].

Also updated the upload artifact to v4 according to this blog post.

@popenta popenta self-assigned this Jan 16, 2025
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/ledger
  ledger_app.py 30-33, 44, 52
Project Total  

This report was generated by python-coverage-comment-action

@popenta popenta merged commit ba60cf8 into feat/next Jan 16, 2025
6 checks passed
@popenta popenta deleted the fix-optional-package branch January 16, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants