Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete_setup endpoint #187

Merged
merged 11 commits into from
Nov 21, 2024
Merged

complete_setup endpoint #187

merged 11 commits into from
Nov 21, 2024

Conversation

andreiblt1304
Copy link
Contributor

No description provided.

@andreiblt1304 andreiblt1304 changed the title Complete phases complete_setup endpoint Nov 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Coverage Summary

Totals

Count Covered %
Lines 6671 3455 51.79
Regions 1872 640 34.19
Functions 696 311 44.68
Instantiations 2435 650 26.69

Files

Expand
File Lines Regions Functions Instantiations
/chain-config/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/chain-config/src/bridge.rs 0.00% 0.00% 0.00% 0.00%
/chain-config/src/lib.rs 100.00% 100.00% 100.00% 16.67%
/chain-config/src/validator_rules.rs 50.00% 26.32% 50.00% 18.03%
/chain-factory/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/chain-factory/src/factory.rs 32.79% 42.86% 40.00% 17.74%
/chain-factory/src/lib.rs 100.00% 100.00% 100.00% 26.32%
/chain-factory/tests/chain_factory_tests.rs 97.25% 88.89% 100.00% 100.00%
/common/max-bridged-amount-module/src/lib.rs 76.92% 62.50% 75.00% 22.86%
/common/proxies/src/chain_config_proxy.rs 18.24% 6.90% 10.00% 12.50%
/common/proxies/src/chain_factory_proxy.rs 39.82% 37.50% 37.50% 42.86%
/common/proxies/src/enshrine_esdt_safe_proxy.rs 56.17% 52.38% 52.38% 25.00%
/common/proxies/src/esdt_safe_proxy.rs 31.93% 33.33% 33.33% 21.62%
/common/proxies/src/fee_market_proxy.rs 50.68% 29.17% 40.00% 29.87%
/common/proxies/src/header_verifier_proxy.rs 90.36% 85.71% 85.71% 52.38%
/common/proxies/src/testing_sc_proxy.rs 0.00% 0.00% 0.00% 0.00%
/common/proxies/src/token_handler_proxy.rs 83.33% 80.00% 80.00% 63.16%
/common/setup-phase/src/lib.rs 80.00% 66.67% 75.00% 23.08%
/common/token-whitelist/src/lib.rs 26.67% 31.25% 50.00% 15.62%
/common/transaction/src/lib.rs 60.45% 40.15% 46.97% 39.48%
/common/transaction/src/transaction_status.rs 0.00% 0.00% 0.00% 0.00%
/common/tx-batch-module/src/lib.rs 100.00% 83.33% 100.00% 36.36%
/common/utils/src/lib.rs 81.25% 67.74% 80.00% 23.38%
/enshrine-esdt-safe/interactor/src/config.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/interactor/src/interactor_main.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/src/common/storage.rs 100.00% 66.67% 100.00% 26.32%
/enshrine-esdt-safe/src/from_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/enshrine-esdt-safe/src/from_sovereign/transfer_tokens.rs 90.08% 82.35% 83.33% 32.56%
/enshrine-esdt-safe/src/lib.rs 91.43% 82.35% 100.00% 24.07%
/enshrine-esdt-safe/src/to_sovereign/create_tx.rs 95.41% 93.75% 100.00% 34.29%
/enshrine-esdt-safe/src/to_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/enshrine-esdt-safe/tests/enshrine_esdt_safe_blackbox_test.rs 99.88% 98.51% 100.00% 100.00%
/esdt-safe/interactor/src/interactor_main.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/src/from_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/esdt-safe/src/from_sovereign/token_mapping.rs 1.10% 5.41% 5.26% 5.71%
/esdt-safe/src/from_sovereign/transfer_tokens.rs 41.63% 50.00% 75.00% 31.91%
/esdt-safe/src/lib.rs 76.47% 75.00% 66.67% 16.67%
/esdt-safe/src/to_sovereign/create_tx.rs 45.51% 50.94% 62.50% 22.86%
/esdt-safe/src/to_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/esdt-safe/tests/bridge_blackbox_tests.rs 86.16% 92.86% 91.67% 91.67%
/fee-market/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/fee-market/src/fee_common.rs 100.00% 75.00% 100.00% 29.17%
/fee-market/src/fee_type.rs 85.29% 53.66% 64.29% 29.76%
/fee-market/src/lib.rs 66.67% 85.71% 66.67% 26.79%
/fee-market/src/price_aggregator.rs 0.00% 0.00% 0.00% 0.00%
/fee-market/src/subtract_fee.rs 42.86% 37.50% 43.75% 17.74%
/fee-market/tests/fee_market_blackbox_test.rs 91.30% 88.64% 100.00% 100.00%
/header-verifier/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/header-verifier/src/lib.rs 92.21% 91.18% 91.67% 53.72%
/header-verifier/tests/header_verifier_blackbox_test.rs 100.00% 100.00% 100.00% 100.00%
/sovereign-forge/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/src/common/storage.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/src/common/utils.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/src/lib.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/src/phases.rs 0.00% 0.00% 0.00% 0.00%
/testing-sc/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/testing-sc/src/lib.rs 0.00% 0.00% 0.00% 0.00%
/token-handler/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/token-handler/src/common_storage.rs 100.00% 50.00% 100.00% 21.05%
/token-handler/src/lib.rs 100.00% 100.00% 100.00% 27.91%
/token-handler/src/transfer_tokens.rs 50.52% 36.67% 66.67% 30.30%
/token-handler/tests/token_handler_blackbox_tests.rs 94.82% 95.24% 100.00% 100.00%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Contract comparison - from 798f72a to ec726c5

Path                                                                                             size                  has-allocator                     has-format
chain-config-full.wasm 5541 false without message
chain-config-view.wasm 626 false None
chain-config.wasm 5541 false without message
enshrine-esdt-safe-full.wasm 21964 ➡️ 21878 🟢 false without message
enshrine-esdt-safe-view.wasm 626 false None
enshrine-esdt-safe.wasm 21964 ➡️ 21878 🟢 false without message
esdt-safe.wasm 23021 ➡️ 22935 🟢 false without message
esdt-safe-view.wasm 626 false None
esdt-safe-full.wasm 23022 ➡️ 22936 🟢 false without message
testing-sc.wasm 461 false None
testing-view.wasm 626 false None
testing-sc-full.wasm 461 false None
fee-market.wasm 11570 false without message
fee-market-view.wasm 626 false None
soveriegn-forge-view.wasm 626 false None
sovereign-forge-full.wasm 5246 ➡️ 5833 🔴 false without message
sovereign-forge.wasm 5246 ➡️ 5833 🔴 false without message
chain-factory-full.wasm 5507 false without message
chain-factory-view.wasm 626 false None
chain-factory.wasm 5507 false without message
header-verifier-full.wasm 4572 false without message
header-verifier.wasm 4572 false without message
multisig-view.wasm 626 false None
token-handler-view.wasm 626 false None
token-handler-full.wasm 9359 false without message
token-handler.wasm 9359 false without message

@andreiblt1304
Modified complete_setup logic
1db480b 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304 andreiblt1304 marked this pull request as ready for review November 20, 2024 14:28
axenteoctavian
axenteoctavian reviewed Nov 21, 2024
View reviewed changes
sovereign-forge/src/phases.rs Show resolved Hide resolved
common/setup-phase/src/lib.rs Outdated
self.require_setup_phase();

self.setup_phase_complete().set(true);
fn require_setup_complete(&self, caller_shard_id: u32) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don' need caller_shard_id

common/setup-phase/src/lib.rs
self.is_setup_phase_complete(),
"The setup is not completed in shard {}",
caller_shard_id
);
}

fn require_caller_initiator(&self) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made it an inline function, might as well use it to make the endpoint as short as possible

@andreiblt1304
Fix after review
35b679c 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Moved variables
ec726c5 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304 andreiblt1304 merged commit 321826d into feat/sovereign-forge Nov 21, 2024
7 checks passed
@andreiblt1304 andreiblt1304 deleted the complete-phases branch December 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axenteoctavian axenteoctavian axenteoctavian approved these changes

@alyn509 alyn509 alyn509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreiblt1304 @alyn509 @axenteoctavian