initial gnome module #19
Conversation
|
Sorry for the delayed response on this, it looks really good! I don't have any gnome experience at all so if you think that this is useful in its current state then I will go ahead and merge it. I probably won't advertise that muon has gnome module support until more things are fleshed out but I think this is a great start! Part of the delay has been that I have been working on a refactor of the core parser/interpreter of muon that should make the execution of script modules a lot more robust and performant. |
|
i cannot express in words how cool and awesome you are for taking the time to maintain muon and do all these things, it's almost like as if you love doing this |
|
Hmm, this refactor is taking longer than I thought. I'd like to go ahead merge this though so I can use it to test stuff on. I feel like it is a good base for the rest of the gnome module and might be useful for other people who want to reference it when writing script modules. If you mark the gnome test as failing and the PR ready for review I'll get it in and then fix issues as they come. |
|
The gnome module is incomplete, and lacks GObject. The rest of the important functions needed to setup rudimentary simple Gnome projects (Without GObject, GTK can be built) is supplied by the gnome module. |
|
ima merge this soon |
|
latest commit untested and only rebased (and formatted) (and installed glib deps for CI) |
apprehensions
force-pushed
the
master
branch
4 times, most recently
from
2686c68 to
d8a7c30
Compare
|
merged 354eaea |
|
Why has this been merged? I was still waiting on some replies to questions that would have easied testing and implementation of the gnome module. |
|
Ah, I thought you were done as in not going to work on it anymore. I was waiting for a long time to merge as I worked through other things, in particular rewriting the analyzer and script module support. I went ahead and merged so I could begin working on it, but I could continue in this branch as well. I fixed a few small bugs already! I think this looks like a good base for the gnome module but if you are really worried about having it in master I could add a warning when it gets imported. |
No description provided.