Update mupq due to mupq PR #161 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I haven't done extensive testing as there are just too many schemes. However, I did run tests, test vectors and benchmarks for all variants of both Falcon and ML-DSA with qemu, and for Falcon only with the Nucleo-L4R5ZI board.
There was an error with the test vectors of the
cleanimplementation of Falcon-1024 with qemu, but it also fails onmaster, so I guess it's unrelated. EDIT: apparently related to #373 (comment), and I can confirm I havearm-none-eabi-gcc (Arm GNU Toolchain 14.2.Rel1 (Build arm-14.52)) 14.2.1 20241119.Also, haven't updated benchmarks/skiplists as they're not affected.