Skip to content

Commit

Permalink
go: remove searchpaths and searchpath from GoArchive and GoArchiveData (
Browse files Browse the repository at this point in the history
bazel-contrib#2452)

These are thoroughly obsolete and have been deprecated for a while.

For bazel-contrib#2448
  • Loading branch information
Jay Conrod authored Apr 21, 2020
1 parent 8f4ebbd commit 41fd82c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
3 changes: 0 additions & 3 deletions go/private/actions/archive.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def emit_archive(go, source = None):
out_export = go.declare_file(go, path = lib_name[:-len(".a")] + ".x")
else:
out_export = None
searchpath = out_lib.path[:-len(lib_name)]
testfilter = getattr(source.library, "testfilter", None)
out_cgo_export_h = None # set if cgo used in c-shared or c-archive mode

Expand Down Expand Up @@ -137,7 +136,6 @@ def emit_archive(go, source = None):
srcs = as_tuple(source.srcs),
orig_srcs = as_tuple(source.orig_srcs),
data_files = as_tuple(data_files),
searchpath = searchpath,
)
x_defs = dict(source.x_defs)
for a in direct:
Expand All @@ -150,7 +148,6 @@ def emit_archive(go, source = None):
source = source,
data = data,
direct = direct,
searchpaths = depset(direct = [searchpath], transitive = [a.searchpaths for a in direct]),
libs = depset(direct = [out_lib], transitive = [a.libs for a in direct]),
transitive = depset([data], transitive = [a.transitive for a in direct]),
x_defs = x_defs,
Expand Down
8 changes: 0 additions & 8 deletions go/providers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,6 @@ rule. Instead, it's referenced in the ``data`` field of GoArchive_.
| Data files that should be available at runtime to binaries and tests built |
| from this archive. |
+--------------------------------+-----------------------------------------------------------------+
| :param:`searchpath` | :type:`string` |
+--------------------------------+-----------------------------------------------------------------+
| **Deprecated:** The search path entry under which the :param:`lib` would be found. |
+--------------------------------+-----------------------------------------------------------------+

GoArchive
~~~~~~~~~
Expand All @@ -295,10 +291,6 @@ which is available through the :param:`data` field.
+--------------------------------+-----------------------------------------------------------------+
| The direct dependencies of this archive. |
+--------------------------------+-----------------------------------------------------------------+
| :param:`searchpaths` | :type:`depset of string` |
+--------------------------------+-----------------------------------------------------------------+
| **Deprecated:** The transitive set of search paths needed to link with this archive. |
+--------------------------------+-----------------------------------------------------------------+
| :param:`libs` | :type:`depset of File` |
+--------------------------------+-----------------------------------------------------------------+
| The transitive set of libraries needed to link with this archive. |
Expand Down

0 comments on commit 41fd82c

Please sign in to comment.