Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: allow users to change dotenv file with env var #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoaoCostaIFG
Copy link

@JoaoCostaIFG JoaoCostaIFG commented Jul 6, 2024

This facilitates the usage of docker secrets for the keys/tokens.

For example on a docker-compose.yml file:

muse:
  image: codetheweb/muse:latest
  container_name: muse
  secrets:
    - muse_env
  environment:
    - ENV_FILE=/run/secrets/muse_env
  restart: unless-stopped
  
secrets:
  muse_env:
    file: /usr/local/etc/muse_env

See relevant dotenv doc

  • I updated the changelog

This facilitates the usage of docker secrets for the keys/tokens.
@JoaoCostaIFG
Copy link
Author

Not sure if I should update the changelog. Please let me know.

Copy link

github-actions bot commented Jul 6, 2024

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-1040 or codetheweb/muse:3d7a85843fc4c8028ac87a0e5df98c477f2fffc1.

Images are available for x86_64 and ARM64.

Latest commit: 3d7a858

@codetheweb
Copy link
Collaborator

Cool!

  1. Let's default ENV_FILE to /config in the Dockerfile so there's a sensible default.
  2. We should also document this in the README.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants