feat: allow running without spotify #1092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835
This PR allows muse to run without a Spotify client ID and secret.
The command will responde with
🚫 ope: Spotify is not enabled!if a user tries to query a song with a Spotify URL.Logic changes
To allow for cases where Spotify isn't available two methods required changes.
addToQueue(): The logic for determining which source to fetch songs from has been moved to thegetSongsservice class inget-songs.ts. Songs are fetched through a single method namedgetSongs()which include the old logic fromaddToQueue(), all other methods in the class has been made private.getYouTubeAndSpotifySuggestionsFor(): Has been refactored, all Spotify logic has been moved to the end of the method (fetching still happens asynchrony at the beginning).PR also updates
YoutubeAPI.search()method to return an empty array if no match is found for the search query. This allows for better error handling other places in the code.