[RFC] Auto-announce when new song comes on #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
|
Just tried this and I like it overall. Didn't even realize that Discord voice channels had a built-in text channel. I think this should probably be a config option rather than always on since some people (myself included) might prefer to have this disabled. |
|
Changes are ready for review. Sorry for the wait, life kept me from getting to this until now. Let me know if you need me to squash my commits. |
|
🚀 Released in Release v2.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #831, at least in part. This is still preliminary, and I'm a TypeScript noob, so comments welcome for what needs to happen for this to merge.
-This adds a
VoiceChannel.send()message to send out the "Now Playing" embed in the voice chat channel when the song changes. This necessitated keeping the reference to the current voice channel as a member of the player class.