Make DockTitleBar customizable #24196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eism
reviewed
Aug 26, 2024
grliszas14
force-pushed
the
customizable_docktitlebar
branch
from
361fd3e
to
21f48c7
Compare
|
@Eism @cbjeukendrup thanks, addressed review comments, quickly tested, ready for 2nd round |
Eism
reviewed
Aug 27, 2024
grliszas14
force-pushed
the
customizable_docktitlebar
branch
from
21f48c7
to
bb38f45
Compare
Eism
approved these changes
Aug 27, 2024
|
Tested on Win10, Mac13.6, LinuxUbuntu22.04 @grliszas14 @Eism There is a regression. After Undock, 3 dots menu becomes inaccessible bandicam.2024-09-06.17-15-37-175.mp4 |
grliszas14
force-pushed
the
customizable_docktitlebar
branch
from
bb38f45
to
c721948
Compare
|
@Eism @DmitryArefiev fixed the issue, please have a look |
|
@grliszas14 @Eism Yeah, all seems to be fine now Tested on Win10, Mac13.6, LinuxUbuntu22.04 - No regressions found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow to set a custom title bar to the dock panel. If no custom title bar provided then default is used.