Give the canvas some margin when first opening a score #24483
Conversation
| @@ -171,6 +171,17 @@ void NotationViewInputController::initZoom() | |||
| currentNotation()->viewState()->setMatrixInited(true); | |||
| } | |||
|
|
|||
| void NotationViewInputController::initCanvasPos() | |||
| { | |||
| double canvasMargin = 10 * DPMM; // 1 centimetre | |||
There was a problem hiding this comment.
I assume it's intentional that this cm is relative to the score size, and not always corresponds to 1 cm on the screen (for example when the default zoom percentage is not 100%).
Maybe it's a bit much though. I would personally prefer something closer to MScore::horizontalPageGapOdd.
If I'm remember correctly (I could be confusing it with something else), the centering was a somewhat controversial choice. The downside is, it makes the score farther from the palette by default on a large monitor, making drag & drop significantly more work. On the other hand, clearly a nice for many purposes. So while I'm not a huge fan of having more and more preferences, the centering seems like a good possibility. Especially if it were tied to the workspace the way UI preferences are supposed to be but aren't - see #15957. Then a "presentation" workspace and an "editing" workspace could use different settings of that preference to good effect. |
mike-spa
force-pushed
the
canvasMargin
branch
from
5477136
to
2bd9198
Compare
|
@cbjeukendrup could you pls take a second look at this after the changes and review/merge :) |
mike-spa
force-pushed
the
canvasMargin
branch
from
2bd9198
to
2f620fb
Compare
|
Looks like 'zoom to page width' etc. is not completely right yet (there's too much margin). Perhaps it has to do with whether Schermopname.2024-09-16.om.12.50.06.mov |
| bool centerHorizontally = totalScoreWidth < viewWidth; | ||
| bool centerVertically = totalScoreHeight < viewHeight; |
There was a problem hiding this comment.
Edge case:
if totalScoreWidth < viewWidth - 2 * canvasMargin, then the score would be centered, but this results in the margin being less than canvasMargin. So, you get this:
instead of
mike-spa
force-pushed
the
canvasMargin
branch
from
2f620fb
to
5ade545
Compare
|
@cbjeukendrup hopefully should be ok now |
cbjeukendrup
force-pushed
the
canvasMargin
branch
from
f4e6db7
to
e8ad30b
Compare
Resolves: #23404
[EDIT]
After consulting with @Tantacrul, I have slightly changed my initial implementation such that:
if there is enough space given the default zoom level and the canvas size, we center it on the canvas
ff there isn't, we align it with a padding to the margin that I've set equal to the gap between pages.
