Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entering a rest switch to input mode #24995

Merged

Conversation

AxelMatstoms
Copy link
Contributor

Resolves: #24282

Entering a rest with the keyboard shortcut now automatically enters input mode and advances to the next note. This is arguably the expected behaviour, since inputing a note switches to input mode.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Addresses issue musescore#24282. Entering a rest with the keyboard shortcut now
automatically enters input mode and advances to the next note. This
is arguably the expected behaviour, since inputing a note switches to
input mode.
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#24282 FIXED

@cbjeukendrup cbjeukendrup merged commit e2b15c7 into musescore:master Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering a rest should automatically switch to Note Entry mode, just as entering a note
3 participants