Fix #24678: Remember which tab was last open within a session #24999
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
reviewed
Oct 1, 2024
|
|
||
| void AppShellConfiguration::setPreferencesDialogLastOpenedPageId(QString lastOpenedPageId) | ||
| { | ||
| LOGI() << "tpacebes nuevo lastOpenedPageId" << lastOpenedPageId; |
There was a problem hiding this comment.
Please remove this before we merge the PR; if all temporary debug log messages would be kept, then the logs would become a bit too cluttered :)
pacebes
force-pushed
the
24678-rememberTabPreferencesWithinSession
branch
2 times, most recently
from
a946d0d
to
8560e29
Compare
cbjeukendrup
reviewed
Oct 1, 2024
Comment on lines
69
to
70
| virtual QString preferencesDialogLastOpenedPageId() const = 0; | ||
| virtual void setPreferencesDialogLastOpenedPageId(QString lastOpenedPageId) = 0; |
There was a problem hiding this comment.
In this case, a "const reference" can be used in both methods, to prevent unnecessarily creating a copy of the QString:
Suggested change
| virtual QString preferencesDialogLastOpenedPageId() const = 0; | |
| virtual void setPreferencesDialogLastOpenedPageId(QString lastOpenedPageId) = 0; | |
| virtual const QString& preferencesDialogLastOpenedPageId() const = 0; | |
| virtual void setPreferencesDialogLastOpenedPageId(const QString& lastOpenedPageId) = 0; |
Comment on lines
146
to
149
| if (configuration()->preferencesDialogLastOpenedPageId().isEmpty()) { | ||
| setCurrentPageId("general"); | ||
| } else { | ||
| setCurrentPageId(configuration()->preferencesDialogLastOpenedPageId()); |
There was a problem hiding this comment.
Let's prevent calling configuration()->preferencesDialogLastOpenedPageId() twice:
Suggested change
| if (configuration()->preferencesDialogLastOpenedPageId().isEmpty()) { | |
| setCurrentPageId("general"); | |
| } else { | |
| setCurrentPageId(configuration()->preferencesDialogLastOpenedPageId()); | |
| const QString& lastOpenedPageId = configuration()->preferencesDialogLastOpenedPageId(); | |
| if (lastOpenedPageId.isEmpty()) { | |
| setCurrentPageId("general"); | |
| } else { | |
| setCurrentPageId(lastOpenedPageId); |
pacebes
force-pushed
the
24678-rememberTabPreferencesWithinSession
branch
from
8560e29
to
27b18da
Compare
pacebes
force-pushed
the
24678-rememberTabPreferencesWithinSession
branch
from
27b18da
to
5a69765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24678
This change remembers the tab you where within the Preferences window when opening the window again within the same session.