-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #23458: Batch conversion silently fails when the output is an array of files #26229
Fix #23458: Batch conversion silently fails when the output is an array of files #26229
Conversation
HI I don't know if I have done something wrong, sorry. I would appreciate any feedback about what I should do now ! Thanks |
It looks like you accidentally amended the topmost commit on/from the master branch, instead of creating a new commit. To fix, you could rebase your branch again on top of the latest master; after that, the topmost commit should contain only your own changes, but still have the wrong commit message and author. I'd say the easiest way to fix that, is undoing the commit, using |
df32bb7
to
add7f2a
Compare
Hm... it looks like the same thing happened again, now with a different commit. Are you perhaps using some Git software that somehow got stuck in "amend" commit mode? |
I'm affraid I have even worsened the problem. Again, I don't know how |
Deleting a PR isn't possible, but you can close this on and create a new one. But I don't expect that will change much. But how are you creating the commit, are you using the command line, or a GUI program? |
I don't know. I have used the same software as always. It's the first time I have had this problem. I will start again with a new MuseScore instance recreated from zero to avoid any problem. Please, delete, or whatever necessary, this PR |
You could do that, but that's probably unnecessarily time-consuming. Which software are you using? |
The same as always. I don't know what was my mistake. Anyway I have created a different pull request which has worked. pacebes@cozuelos:/C/D/MS_23458$ git --version |
Fix a bunch of different issue connected to local time signatures
Resolves: #23458
This PR allow json batch conversion files including an array of output files such as: