Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment corrections with accidentals of different sizes #26457

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Alignment corrections with accidentals of different sizes #26457

wants to merge 3 commits into from
+6 −3

Conversation

mike-spa
Copy link
Contributor

Resolves: #24043

  • Accidentals are aligned by their right side, not by their left (which obvs is only relevant if they have different size)
  • The threshold for deciding to align offset octaves or not is scaled by the average magnification of the two accidentals

@mike-spa
Align accidentals to the right side
3207639 
This is only relevant for accidentals with different mag, see musescore#24043, otherwise aligning by the left or right side makes no difference.
@mike-spa
Scale threshold for vertical alignment by magnification
dd28044
@mike-spa
add vtest
ee18e65
@mike-spa mike-spa requested a review from oktophonie February 12, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oktophonie oktophonie Awaiting requested review from oktophonie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accidental alignment is not necessary between full-size and cue-size notes
1 participant
@mike-spa