Fix extending range selection to the left for the first time #26788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
commented
Feb 27, 2025
| if (endSegment && elementStaffIdx != muse::nidx) { | ||
| Fraction tick = startSegment->tick(); | ||
| Fraction etick = endSegment->tick(); |
There was a problem hiding this comment.
This change is unrelated, but I noticed that it's weird to use endSegment before doing a null check on it...
RomanPudashkin
approved these changes
Feb 27, 2025
|
It is still a little different from 4.4.4 when I return to the first note I selected video1617270557.mp4 |
cbjeukendrup
force-pushed
the
fix_extend_range_selection_to_left_first_time
branch
from
545e8d7 to
37e4a81
Compare
|
@zacjansheski Thanks, that should be addressed now! |
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
cbjeukendrup
deleted the
fix_extend_range_selection_to_left_first_time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26720