Update to rust 2021 edition #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get this project to compile in 2022.
I had some issues with the Cargo.lock file missing which caused some dependencies to not work out of the box so I updated everything to the latest versions.
This upgrade caused a few issues with generic types, especially Vector2 and Point2 which are now using DVec2 from glam.
The main issue in this that I haven't yet worked through is a change in nannou_audio::stream::Shared that means in is now !Sync as it now contains a cpal::Stream which is !Sync. I've currently resorted to commenting out starting the Soundscape update thread and it's just returning None instead of Some(thread) (the instantiation of which is currently commented out so to make the compiler happy)