Snapcast fix lost state when stop #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Oct 29, 2024
| @@ -432,6 +432,7 @@ async def cmd_volume_set(self, player_id: str, volume_level: int) -> None: | |||
| async def cmd_stop(self, player_id: str) -> None: | |||
| """Send STOP command to given player.""" | |||
| player = self.mass.players.get(player_id, raise_unavailable=False) | |||
| player.elapsed_time = time.time() | |||
There was a problem hiding this comment.
Well then there is a bug somewhere else.
With this it works as it should.
The problem is that when pausing, it goes back to the first song in the queue.
It also clears the list of songs already played.
Do you have any idea what it could be ?
|
I understand that the code does not make sense, but I leave a video showing the error and the “solution”. Current status in branch dev: current_dev_branch.mp4With the change in the pr: fix.mp4 |
|
Does this make more sense? |
marcelveldt
approved these changes
Nov 2, 2024
|
I have been trying this a little more and it does not solve the error, the first solution does, the second does not, it is strange because it certainly does not make sense. |
|
Move the change to cmd_stop if it seems to fix it. It shouldn't make a difference though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.