Merge pull request #5 from muskangupta042002/feature/NewChanges

fixed error
muskangupta042002 · Sep 10, 2023 · 7926ba5 · 7926ba5
2 parents b22bff8 + 3a5f4e1
commit 7926ba5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/BuildAndTestSource.yml b/.github/workflows/BuildAndTestSource.yml
@@ -13,7 +13,6 @@ on:
 jobs:
   build_test:
     runs-on: ubuntu-latest
-    if: github.event_name == 'pull_request' && github.event.action != 'closed'
     steps:
       - uses: actions/checkout@v3
       - name: Set up JDK 17
@@ -23,10 +22,13 @@ jobs:
           distribution: "temurin"
           cache: maven
       - name: Build with Maven
+        if: github.event_name == 'pull_request' && github.event.action != 'closed'
         run: mvn -B package --file pom.xml
       - name: Test with Maven
+        if: github.event_name == 'pull_request' && github.event.action != 'closed'
         run: mvn test
       - name: Upload JAR as Artifact
+        if: github.event_name == 'pull_request' && github.event.action != 'closed'
         uses: actions/upload-artifact@v2
         with:
           name: springrolls

diff --git a/src/main/java/click/akshaygupta/springrolls/GreetingController.java b/src/main/java/click/akshaygupta/springrolls/GreetingController.java
@@ -9,7 +9,7 @@
 public class GreetingController {
 
 	@GetMapping("/greeting")
-	public String greeting(@RequestParam(name="name", required=false, defaultValue="World!") String name, Model model) {
+	public String greeting(@RequestParam(name="name", required=false, defaultValue="World!!") String name, Model model) {
 		model.addAttribute("name", name);
 		return "greeting";
 	}