Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake support #120

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

CMake support #120

wants to merge 2 commits into from

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Oct 22, 2022

The CLion IDE (IntelliJ) works normally only with CMake.
Otherwise I can't debug it.
I added the CMakeList.txt just for this case.
It doesn't work completely so you may not merge it.
Anyway the PR may be useful for others like me

@mwarning
Copy link
Owner

What does not work? It compiles for me.

@stokito
Copy link
Contributor Author

stokito commented Oct 23, 2022

not all features are migrated: natpmp, libcadnode etc.

@mwarning
Copy link
Owner

ah, ok. understood.

@stokito
Copy link
Contributor Author

stokito commented Oct 30, 2022

The Makefile has this:

ifeq ($(OS),Windows_NT)
  OBJS += build/unix.o build/windows.o
else
  OBJS += build/unix.o
endif

E.g. even for a Windows we need to compile the unix.c file. Is this correct or was made by a mistake?

@mwarning
Copy link
Owner

unix.c is need to compile on Windows since Cygwin is used.

@stokito
Copy link
Contributor Author

stokito commented Oct 30, 2022

so this file is anyway always added then we can move it too list of all core files

@stokito stokito marked this pull request as draft October 30, 2022 13:13
@mwarning
Copy link
Owner

Yes, that sounds like a good idea.

@mwarning mwarning force-pushed the master branch 2 times, most recently from 25b5ca0 to 7621f33 Compare June 17, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants