Feature/modal global loading indicator #229
Conversation
| itemsAlreadyLoaded = 0; | ||
| }; | ||
|
|
||
| var executeCallbacks = function (cbs, args, scope) { |
There was a problem hiding this comment.
Didn't know that the letters a,l,l,a,c,k are expensive. Please fix param names for better reading. Also args should be arguments
There was a problem hiding this comment.
arguments can not be used because it is a reserved JavaScript word
There was a problem hiding this comment.
valid reason for not using arguments
| * @description | ||
| * This service manages loading processes. It can be used e.g. by a httpInterceptor to register a loading process | ||
| */ | ||
| .service('Loading', function ($timeout) { |
There was a problem hiding this comment.
We already have a service called 'Loading' (see relution/common). How are name collisions handled
There was a problem hiding this comment.
It will use the one the is registered first, the other one is just ignored. Next step is to remove the Loading service from the portal
There was a problem hiding this comment.
So in fact you moved the loading service into the UI-Kit...
There was a problem hiding this comment.
Yes with some small modifications, a merge request for the portal will come as soon as this mr is released in a new uikit version
| service.start(); | ||
|
|
||
| service.done(); | ||
|
|
There was a problem hiding this comment.
Add $timeout.flush()... i expect that the test will crash
There was a problem hiding this comment.
Yes it will fail because there are no $timeouts to flush but this is the expected behaviour
There was a problem hiding this comment.
I added a check in afterEach to verify that there is no outstanding $timeout task
Fix #229