Recommend using private constants

myclabs · Jan 10, 2018 · cedc9f7 · cedc9f7
1 parent 955f570
commit cedc9f7
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -33,11 +33,12 @@ use MyCLabs\Enum\Enum;
  */
 class Action extends Enum
 {
-    const VIEW = 'view';
-    const EDIT = 'edit';
+    private const VIEW = 'view';
+    private const EDIT = 'edit';
 }
 ```
 
+Note the `private` keyword requires PHP > 7.1, you can omit it on PHP 7.0.
 
 ## Usage
 
@@ -80,8 +81,8 @@ Static methods:
 ```php
 class Action extends Enum
 {
-    const VIEW = 'view';
-    const EDIT = 'edit';
+    private const VIEW = 'view';
+    private const EDIT = 'edit';
 }
 
 // Static method:
@@ -96,7 +97,7 @@ If you care about IDE autocompletion, you can either implement the static method
 ```php
 class Action extends Enum
 {
-    const VIEW = 'view';
+    private const VIEW = 'view';
 
     /**
      * @return Action
@@ -116,8 +117,8 @@ or you can use phpdoc (this is supported in PhpStorm for example):
  */
 class Action extends Enum
 {
-    const VIEW = 'view';
-    const EDIT = 'edit';
+    private const VIEW = 'view';
+    private const EDIT = 'edit';
 }
 ```