修复maxHeight失效

mylhyl · Jul 19, 2021 · 37e9b7b · 37e9b7b
1 parent f8a51bb
commit 37e9b7b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 21 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -10,7 +10,8 @@
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:supportsRtl="true"
-        android:theme="@style/AppTheme">
+        android:theme="@style/AppTheme"
+        android:usesCleartextTraffic="true">
 
         <meta-data
             android:name="design_width_in_dp"

diff --git a/app/src/main/java/com/mylhyl/circledialog/sample/MainActivity.java b/app/src/main/java/com/mylhyl/circledialog/sample/MainActivity.java
@@ -80,6 +80,7 @@ public void onItemClick(BaseQuickAdapter adapter, View view, int position) {
                 dialogFragment = new CircleDialog.Builder()
                         //.setTypeface(typeface)
                         .setTitle("标题")
+                        .setMaxHeight(0.8f)
                         //.setManualClose(true)
                         .configTitle(params -> params.isShowBottomDivider = true)
                         .setWidth(0.5f)
@@ -723,6 +724,8 @@ protected void convert(BaseViewHolder helper, WeiBoItem item) {
                 new CircleDialog.Builder()
                         //  .setTypeface(typeface)
                         .setWidth(0.5f)
+                        .setCloseResId(R.mipmap.ic_close, 27)
+                        .setCloseGravity(CloseParams.CLOSE_TOP_RIGHT)
                         .setAdResId(R.mipmap.ic_zfbxcc, (view18, position18) -> {
                             Toast.makeText(MainActivity.this, "点击了"
                                     , Toast.LENGTH_SHORT).show();

diff --git a/circledialog/src/main/java/com/mylhyl/circledialog/AbsBaseCircleDialog.java b/circledialog/src/main/java/com/mylhyl/circledialog/AbsBaseCircleDialog.java
@@ -9,8 +9,10 @@
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
+import android.view.ViewTreeObserver;
 import android.view.Window;
 import android.view.WindowManager;
+import android.widget.FrameLayout;
 
 import androidx.annotation.ColorInt;
 import androidx.annotation.FloatRange;
@@ -98,21 +100,21 @@ public void onDismiss(DialogInterface dialog) {
 
     @Override
     public void onStart() {
-//        if (getView() != null && mMaxHeight > 0) {
-//            getView().getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
-//                @Override
-//                public void onGlobalLayout() {
-//                    int height = getView().getHeight();
-//                    int screenHeight = mSystemBarConfig.getScreenHeight();
-//                    int maxHeight = (int) (screenHeight * mMaxHeight);
-//                    if (height > maxHeight) {
-//                        getView().getViewTreeObserver().removeOnGlobalLayoutListener(this);
-//                        getView().setLayoutParams(new FrameLayout.LayoutParams(
-//                                FrameLayout.LayoutParams.MATCH_PARENT, maxHeight));
-//                    }
-//                }
-//            });
-//        }
+        if (getView() != null && mMaxHeight > 0) {
+            getView().getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
+                @Override
+                public void onGlobalLayout() {
+                    int height = getView().getHeight();
+                    int screenHeight = mSystemBarConfig.getScreenHeight();
+                    int maxHeight = (int) (screenHeight * mMaxHeight);
+                    if (height > maxHeight) {
+                        getView().getViewTreeObserver().removeOnGlobalLayoutListener(this);
+                        getView().setLayoutParams(new FrameLayout.LayoutParams(
+                                FrameLayout.LayoutParams.MATCH_PARENT, maxHeight));
+                    }
+                }
+            });
+        }
         Dialog dialog = getDialog();
         if (dialog != null) {
             dialog.setCanceledOnTouchOutside(mCanceledOnTouchOutside);
@@ -324,11 +326,6 @@ private void setDialogGravity(Dialog dialog) {
         } else {
             wlp.width = (int) mWidth;
         }
-        if (mMaxHeight > 0 && mMaxHeight <= 1) {
-            int screenHeight = mSystemBarConfig.getScreenHeight();
-            int maxHeight = (int) (screenHeight * mMaxHeight);
-            wlp.height = maxHeight;
-        }
         wlp.gravity = mGravity;
         wlp.x = mX;
         wlp.y = mY;