Fix warning background "sticky" behavior #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a warning error has been logged in the LimeSuiteGUI all the following messages had an yellow background, which is an unexpected behavior. Apparently it was caused by the previous fix in the area which made it so the text color is restored to its default value. Somehow it had an effect on the background color behavior: as if there is some implicit behavior when neither of the foreground and background are set in the style when it is set as default to the message field. It is hard to tell now if this was an oversight in the previous fix, or is it something changed in the wxWidgets library. In any case the logging behavior has been verified once again on both Dark and Light themes on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a warning error has been logged in the LimeSuiteGUI all the following messages had an yellow background, which is an unexpected behavior.
Apparently it was caused by the previous fix in the area which made it so the text color is restored to its default value. Somehow it had an effect on the background color behavior: as if there is some implicit behavior when neither of the foreground and background are set in the style when it is set as default to the message field.
It is hard to tell now if this was an oversight in the previous fix, or is it something changed in the wxWidgets library. In any case the logging behavior has been verified once again on both Dark and Light themes on macOS.