Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe API upgrade #8405

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Stripe API upgrade #8405

wants to merge 4 commits into from

Commits on Oct 10, 2024

  1. Update Pro invoice specs 

    Use Stripe mocks instead of doubles. Ideally this would mean if the
attributes change upstream we get test failures, unfortunately this
doesn't appear to happen due to how stripe-ruby-mock works.
    @gbp
    gbp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8e05eb2 View commit details
    Browse the repository at this point in the history

  2. Upgrade Stripe API version 

    Bumps the API version to the latest version support by stripe-ruby-mock.

Also remove gem lock allowing us to upgrade both stripe-ruby-mock and
the main stripe gem.

Fixes broken tests and other changes which aren't testable, such as:
1. Invoice#date being rename Invoice#created
2. Plan#name being moved to Plan#product & Product#name and not loaded/
   expanded automatically.
    @gbp
    gbp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6eda678 View commit details
    Browse the repository at this point in the history

  3. Replace deprecated Stripe save calls 

    These have been replaced with calls to `create` or `update`.
    @gbp
    gbp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    dc49b45 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @gbp
    gbp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    499acb0 View commit details
    Browse the repository at this point in the history