Kingston/Sutton Echo changes #5334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5334 +/- ##
==========================================
- Coverage 82.44% 81.56% -0.88%
==========================================
Files 416 417 +1
Lines 32911 33203 +292
Branches 5286 5343 +57
==========================================
- Hits 27132 27081 -51
- Misses 4217 4504 +287
- Partials 1562 1618 +56 ☔ View full report in Codecov by Sentry. |
dracos
force-pushed
the
kingston-sutton-echo-changeover
branch
3 times, most recently
from
73a2535 to
25b58a0
Compare
So we can change over to new Echo handling, have each request it directly, so can switch separately.
As it is now in a separate Echo instance, only relevant results will be returned.
There is one service task per service unit; container information is now on the service unit, not the task; all the IDs have changed.
dracos
force-pushed
the
kingston-sutton-echo-changeover
branch
from
25b58a0 to
2bd99ca
Compare
There is one service task per service unit; container information is now on the service unit, not the task; all the IDs have changed.
There is one service task per service unit; container information is now on the service unit, not the task; all the IDs have changed.
dracos
force-pushed
the
kingston-sutton-echo-changeover
branch
from
2bd99ca to
da2f6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/mysociety/societyworks/issues/4725 (core ID changes) [skip changelog]
This PR starts with some core changes - simplifying a bit of code to auto-use it where needed (will be useful in future), finds some more Echo IDs that were previously missed, changing the garden end date format, and making sure shared Kingston/Sutton code uses no fixed IDs at all (as they will change over independently of each other at different times).
It then makes a copy of the SLWP code, removes now-unneeded parts of that, and updates with new Echo IDs and locations for data (but at that point is not used by anything). After that's done, it moves Sutton and then Kingston to the new SLWP copy, also removing unneeded parts of the code and updating for new Echo IDs and locations.
Bulky and Garden tests are marked to be skipped; the coverage stats are poor because at this point we're not dealing correctly with requests, garden, or bulky, and much of the copied code is not yet being tested.
For going live, as Sutton is going live before Kingston, the Sutton commits can be taken out and merged separately without the Kingston ones; both can go on staging at present for testing.