Only update 'lastupdate' when the update is new. #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5350 +/- ##
==========================================
+ Coverage 82.44% 82.86% +0.42%
==========================================
Files 416 416
Lines 32911 33812 +901
Branches 5286 5584 +298
==========================================
+ Hits 27132 28017 +885
- Misses 4217 4233 +16
Partials 1562 1562 ☔ View full report in Codecov by Sentry. |
neprune
force-pushed
the
fix-old-updates-applying-state
branch
from
3dd7a67 to
13176c8
Compare
neprune
changed the title
neprune
force-pushed
the
fix-old-updates-applying-state
branch
from
13176c8 to
4a71572
Compare
neprune
force-pushed
the
fix-old-updates-applying-state
branch
from
4a71572 to
64d267e
Compare
dracos
approved these changes
Feb 3, 2025
| @@ -281,7 +281,9 @@ sub _process_update { | |||
| # insertion. We also then need a clone, otherwise the setting of lastupdate | |||
| # will *also* reshift comment->created's time zone to TIME_ZONE. | |||
| my $created = $comment->created->set_time_zone(FixMyStreet->local_time_zone); | |||
| $p->lastupdate($created->clone); | |||
| if ($created > $p->lastupdate) { | |||
There was a problem hiding this comment.
I think this works even given the time zone statement above, because both things by here should have a time zone for comparison purpose, I think.
neprune
force-pushed
the
fix-old-updates-applying-state
branch
from
64d267e to
61e7964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mysociety/societyworks/issues/4748
[skip changelog]