[Bexley] Green Garden Waste #5375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO lots more probably. It does not know until you have picked DD/CC that DD is cheaper for the first bin. Perhaps can be implemented as a 5GBP discount when you click the DD option?
- Add support for internal Direct Debit processing in Bexley - Implement new direct_debit_internal method in Waste controller - Add direct_debit_collection_method method to Default and Bexley cobrands - Update garden subscription form to handle internal Direct Debit flow - Add bank details form validation and formatting - Add tests for Direct Debit submission process
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5375 +/- ##
==========================================
- Coverage 82.46% 82.32% -0.15%
==========================================
Files 417 424 +7
Lines 33017 34115 +1098
Branches 5313 5480 +167
==========================================
+ Hits 27228 28084 +856
- Misses 4218 4429 +211
- Partials 1571 1602 +31 ☔ View full report in Codecov by Sentry. |
… when paying by DD.
This allows staff to setup a Direct Debit on behalf of a customer.
Ensures reports are confirmed after DD is set up so they get sent to Agile
The Access PaySuite DD API does not validate bank details when creating new contracts, so we first pass them to a totally separate Access PaySuite 'bankchecker' API to make sure they're good.
davea
force-pushed
the
bexley-ww-garden-reviewed
branch
from
c98fa56 to
7071264
Compare
This applies to all bins as confirmed by Bexley here: https://3.basecamp.com/4020879/buckets/40373795/todos/8289633594#__recording_8374002022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made up of smaller things that have already been individually reviewed:
[skip changelog]