-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return value from updateMd5CacheItem #419
base: master
Are you sure you want to change the base?
Conversation
Return a value so that a second call to updateMd5CacheItem on the stored promise is given the input the first call received to keep from throwing an error.
It seems like this pull-request at least partially solves some of the issues users are having in #416, we got some reports from Next.js users too (Next.js now uses hard-source-webpack-plugin since version 7). @mzgoddard could you release this patch / is there anything I can do to help? |
@mzgoddard Any updates on this issue?? Update: It already caused some UI broken in our app ... |
@mzgoddard what can we do to help? I'm blocked from using this plugin until this bug is resolved (fails every time for me - applying the fix here resolves the issue). |
+1 |
There's a non-trivial amount of tests failing on CI, which I imagine is the cause for blocking here. If someone can fix the build that would probably unstick this PR. I don't know if @mzgoddard has any quick insights on what might be causing the test failures before anyone else dives in though? |
any updates on this? |
any updates? |
Return a value so that a second call to updateMd5CacheItem on the
stored promise is given the input the first call received to keep from
throwing an error.