Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNOME 42 support #218

Merged
merged 12 commits into from
Apr 29, 2022
Merged

GNOME 42 support #218

merged 12 commits into from
Apr 29, 2022

Conversation

mzur
Copy link
Owner

@mzur mzur commented Apr 28, 2022 •
edited
Loading

Known issues to be resolved:

ebeem and others added 10 commits April 7, 2022 08:06
@ebeem @ettavolt
fix _syncStacking error
b0c4b11
@ettavolt
Support GJS 1.72: call hookVfunc on gobject prototype.
1b51812 
Properly export WorkspaceAnimationController
@ettavolt
Copy 42's changes to ControlsManagerLayout._computeWorkspacesBoxForSt…
7c9c28f 
…ate.

Mark Shell 42 as targeted.
@ettavolt
Some overrides for inaccessible Shell UI bits.
a3df0ae
@mzur
Update default settings
c8a87ef
@mzur
Move ControlsState import
423e1e1
@mzur
Move code to better match upstream
09af7f3
@mzur
Update [email protected]/workspacePopup/workspaceAnimation.js
4bd10fb
@mzur
Disable secondaryMonitorDisplayOverride
174fa3c 
The override can be enabled again once the following issue is
resolved and published in a new GNOME version:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2266
@mzur
Merge pull request #217 from ettavolt/gjs-172-shell-42
dc8bf5f 
Support GJS 1.72 Shell 42
@mzur mzur mentioned this pull request Apr 28, 2022
Merged
@mzur
Copy link
Owner Author

mzur commented Apr 29, 2022 •
edited
Loading

I have removed the WorkspaceGroup override (as discussed here #217 (comment)). @ettavolt Any insights you might have regarding this would be appreciated.

In addition, I created #219, #220, #221 and #222 as known issues that should be fixed after the initial release for GNOME 42. Please report any new bugs as separate issues.

I'll create a new release from this state. The extension is at least usable in GNOME 42 despite the issues.

@mzur mzur linked an issue Apr 29, 2022 that may be closed by this pull request
GNOME 42 and GJS >= 1.71 support #212
Closed
@mzur mzur merged commit 3748703 into master Apr 29, 2022
@mzur mzur deleted the gnome-42 branch April 29, 2022 13:44
@ettavolt
Copy link
Contributor

ettavolt commented May 1, 2022

I've been using ebeem's WorkspaceGroup override for some time (it is date 2021-12-01), it was never a part of the mainline. If extension works without - nice, the less overrides we have the better.

From what I see we seem to need just the already submitted const→var changes in the Shell, correct? Unless 221 adds something, though.

@mzur
Copy link
Owner Author

mzur commented May 1, 2022

I've been using ebeem's WorkspaceGroup override for some time (it is date 2021-12-01), it was never a part of the mainline.

Thanks, I didn't remember that this came from ebeem. Do you recall what it was for back then?

From what I see we seem to need just the already submitted const→var changes in the Shell, correct?

Correct. I don't think that we can remove the redundant code until GNOME 43, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GNOME 42 and GJS >= 1.71 support
3 participants
@mzur @ettavolt @ebeem